Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DASH] Pass pl_sip_encoding to SAI #3285

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

theasianpianist
Copy link
Contributor

@theasianpianist theasianpianist commented Sep 10, 2024

What I did
If present, parse pl_sip_encoding field in ENI table and pass it to SAI

Why I did it
pl_sip_encoding was previously deprecated but now has been un-deprecated (see sonic-net/SONiC#1805)

How I verified it

Details if related

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
@theasianpianist
Copy link
Contributor Author

@mukeshmv for viz

@prsunny
Copy link
Collaborator

prsunny commented Sep 10, 2024

Do you need any HLD change? if so, can you please share the link to HLD PR?

@theasianpianist
Copy link
Contributor Author

Do you need any HLD change? if so, can you please share the link to HLD PR?

Yes, will update HLD as well. Will wait to merge this until HLD PR is open

Copy link
Contributor

@mukeshmv mukeshmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prsunny prsunny merged commit 60f9dde into sonic-net:master Sep 11, 2024
17 checks passed
shuaishang pushed a commit to wenwang00/sonic-swss that referenced this pull request Sep 18, 2024
What I did
If present, parse pl_sip_encoding field in ENI table and pass it to SAI

Why I did it
pl_sip_encoding was previously deprecated but now has been un-deprecated (see sonic-net/SONiC#1805)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants