Skip to content

[ZmqOrch] Optimize memory by popping batch size at a time #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prsunny merged 5 commits into from
Oct 9, 2025
Merged

[ZmqOrch] Optimize memory by popping batch size at a time #3910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0370c7
[ZmqOrch] Optimize memory by popping batch size at a time
vivekrnv Jun 26, 2025
b3f8ccf
Use reference instead of redundant copy
vivekrnv Aug 19, 2025
9e5903f
Increase max bulker size
vivekrnv Aug 19, 2025
317be29
Remove hardcoded values
vivekrnv Sep 25, 2025
0e373ff
Merge branch 'master' into pop_batch_zmq
prabhataravind Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion orchagent/dash/dashvnetorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ void DashVnetOrch::addPaValidation(const string& key, VnetMapBulkContext& ctxt)
string underlay_ip_str = to_string(ctxt.metadata.underlay_ip());
string pa_ref_key = ctxt.vnet_name + ":" + underlay_ip_str;

auto vnet_underlay_ips = vnet_table_[ctxt.vnet_name].underlay_ips;
auto& vnet_underlay_ips = vnet_table_[ctxt.vnet_name].underlay_ips;
std::string underlay_sip_str = to_string(ctxt.metadata.underlay_ip());
if (vnet_underlay_ips.find(underlay_sip_str) != vnet_underlay_ips.end())
{
Expand Down
11 changes: 4 additions & 7 deletions orchagent/zmqorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,11 @@ void ZmqConsumer::execute()
{
SWSS_LOG_ENTER();

size_t update_size = 0;
auto table = static_cast<swss::ZmqConsumerStateTable*>(getSelectable());
do
{
std::deque<KeyOpFieldsValuesTuple> entries;
table->pops(entries);
update_size = addToSync(entries);
} while (update_size != 0);

std::deque<KeyOpFieldsValuesTuple> entries;
table->pops(entries);
addToSync(entries);

drain();
}
Expand Down
Loading