[ssw][ha] add ACTION_COUNTER to acl table type#4068
Merged
prsunny merged 3 commits intosonic-net:masterfrom Dec 19, 2025
Merged
[ssw][ha] add ACTION_COUNTER to acl table type#4068prsunny merged 3 commits intosonic-net:masterfrom
prsunny merged 3 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zjswhhh
added
issues for 202505
Request for msft-202506 Branch
and removed
issues for 202505
labels
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the VNet tunnel termination ACL table initialization by adding ACTION_COUNTER to the list of supported actions in the ACL table type definition. Without this fix, when ACL rules attempt to use counters, the SAI layer rejects them with SAI_STATUS_INVALID_PARAMETER because the table type doesn't declare counter support.
Key Changes:
- Added
ACTION_COUNTERto the action_list in the VNetTunnelTermAcl::lazyInit() method - Updated ACL_TABLE_TYPE_ACTIONS to use the concatenated actions string that includes both REDIRECT_ACTION and COUNTER
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yue-fred-gao
approved these changes
Dec 17, 2025
prsunny
previously approved these changes
Dec 18, 2025
Collaborator
|
Can you add a test coverage? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Dec 19, 2025
Collaborator
|
Cherry-pick PR to 202511: #4078 |
balanokia
pushed a commit
to balanokia/sonic-swss
that referenced
this pull request
Dec 20, 2025
What I did Add action counter to acl table type when creating initializing tunnel termination acl table. sign-off: Jing Zhang zhangjing@microsoft.com Why I did it It's added for the acl rules but not for the table today. How I verified it This change was there for our HA development (on a custom branch) but missed on the master branch. It's verified in many demo sessions.
saravanan-nexthop
pushed a commit
to saravanan-nexthop/sonic-swss
that referenced
this pull request
Dec 23, 2025
What I did Add action counter to acl table type when creating initializing tunnel termination acl table. sign-off: Jing Zhang zhangjing@microsoft.com Why I did it It's added for the acl rules but not for the table today. How I verified it This change was there for our HA development (on a custom branch) but missed on the master branch. It's verified in many demo sessions.
saravanan-nexthop
pushed a commit
to saravanan-nexthop/sonic-swss
that referenced
this pull request
Dec 23, 2025
What I did Add action counter to acl table type when creating initializing tunnel termination acl table. sign-off: Jing Zhang zhangjing@microsoft.com Why I did it It's added for the acl rules but not for the table today. How I verified it This change was there for our HA development (on a custom branch) but missed on the master branch. It's verified in many demo sessions. Signed-off-by: Saravanan Sellappa <saravanan@nexthop.ai>
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
Pterosaur
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Jan 6, 2026
What I did Add action counter to acl table type when creating initializing tunnel termination acl table. sign-off: Jing Zhang zhangjing@microsoft.com Why I did it It's added for the acl rules but not for the table today. How I verified it This change was there for our HA development (on a custom branch) but missed on the master branch. It's verified in many demo sessions.
arpit-nexthop
pushed a commit
to nexthop-ai/sonic-swss
that referenced
this pull request
Jan 21, 2026
What I did Add action counter to acl table type when creating initializing tunnel termination acl table. sign-off: Jing Zhang zhangjing@microsoft.com Why I did it It's added for the acl rules but not for the table today. How I verified it This change was there for our HA development (on a custom branch) but missed on the master branch. It's verified in many demo sessions.
Collaborator
|
Cherry-pick PR to msft-202506: Azure/sonic-swss.msft#201 |
mssonicbld
added
Included in msft-202506 Branch
and removed
Created PR to msft-202506 Branch
labels
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
What I did Add action counter to acl table type when creating initializing tunnel termination acl table. sign-off: Jing Zhang zhangjing@microsoft.com Why I did it It's added for the acl rules but not for the table today. How I verified it This change was there for our HA development (on a custom branch) but missed on the master branch. It's verified in many demo sessions. Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add action counter to acl table type when creating initializing tunnel termination acl table.
sign-off: Jing Zhang zhangjing@microsoft.com
Why I did it
It's added for the acl rules but not for the table today.
How I verified it
This change was there for our HA development (on a custom branch) but missed on the master branch. It's verified in many demo sessions.
Details if related
Error logs if missing this PR: