[hft]: Fix TAM type capability enable list#4075
Merged
prsunny merged 6 commits intosonic-net:masterfrom Jan 5, 2026
Merged
Conversation
Signed-off-by: Ze Gan <ganze718@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR fixes the TAM (Telemetry and Monitoring) type capability enable list implementation to make it object-type specific rather than enabling all capabilities unconditionally. Previously, all telemetry capabilities (PORT_STATS, MMU_STATS, and OUTPUT_QUEUE_STATS) were enabled regardless of the object type being monitored, which was ambiguous. The new implementation conditionally enables only the relevant capabilities based on the SAI object type (PORT, BUFFER_POOL, INGRESS_PRIORITY_GROUP, or QUEUE).
Key changes:
- Refactored C++ code to use conditional logic that enables capabilities based on object type
- Updated test to verify at least one capability is enabled rather than requiring all capabilities
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| orchagent/high_frequency_telemetry/hftelprofile.cpp | Replaced unconditional capability enablement with conditional logic based on SAI object type (PORT, BUFFER_POOL, INGRESS_PRIORITY_GROUP, QUEUE), adding error handling for unsupported types |
| tests/test_hft.py | Added flexible validation to check that at least one TAM capability is enabled, accommodating the new object-type-specific capability enablement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
force-pushed
the
fix_tam_type_capability
branch
from
fd24ea9 to
bd453f6
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
force-pushed
the
fix_tam_type_capability
branch
from
bd453f6 to
7d3b645
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ze Gan <ganze718@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
force-pushed
the
fix_tam_type_capability
branch
from
c9429d4 to
a7601ae
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
reviewed
Jan 2, 2026
r12f
left a comment
r12f
left a comment
There was a problem hiding this comment.
the type mapping looks reasonable. approved.
@DavidZagury and @dgsudharsan for viz.
r12f
approved these changes
Jan 4, 2026
prsunny
approved these changes
Jan 5, 2026
arpit-nexthop
pushed a commit
to nexthop-ai/sonic-swss
that referenced
this pull request
Jan 21, 2026
This PR fixes the TAM (Telemetry and Monitoring) type capability enable list implementation to make it object-type specific rather than enabling all capabilities unconditionally. Previously, all telemetry capabilities (PORT_STATS, MMU_STATS, and OUTPUT_QUEUE_STATS) were enabled regardless of the object type being monitored, which was ambiguous. The new implementation conditionally enables only the relevant capabilities based on the SAI object type (PORT, BUFFER_POOL, INGRESS_PRIORITY_GROUP, or QUEUE). Key changes: Refactored C++ code to use conditional logic that enables capabilities based on object type Updated test to verify at least one capability is enabled rather than requiring all capabilities
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-swss.msft#198 |
r12f
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
ganglyu
pushed a commit
to ganglyu/sonic-swss
that referenced
this pull request
Jan 26, 2026
This PR fixes the TAM (Telemetry and Monitoring) type capability enable list implementation to make it object-type specific rather than enabling all capabilities unconditionally. Previously, all telemetry capabilities (PORT_STATS, MMU_STATS, and OUTPUT_QUEUE_STATS) were enabled regardless of the object type being monitored, which was ambiguous. The new implementation conditionally enables only the relevant capabilities based on the SAI object type (PORT, BUFFER_POOL, INGRESS_PRIORITY_GROUP, or QUEUE). Key changes: Refactored C++ code to use conditional logic that enables capabilities based on object type Updated test to verify at least one capability is enabled rather than requiring all capabilities Signed-off-by: ganglyu <glv@nvidia.com>
Collaborator
|
Cherry-pick PR to 202511: #4215 |
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
This PR fixes the TAM (Telemetry and Monitoring) type capability enable list implementation to make it object-type specific rather than enabling all capabilities unconditionally. Previously, all telemetry capabilities (PORT_STATS, MMU_STATS, and OUTPUT_QUEUE_STATS) were enabled regardless of the object type being monitored, which was ambiguous. The new implementation conditionally enables only the relevant capabilities based on the SAI object type (PORT, BUFFER_POOL, INGRESS_PRIORITY_GROUP, or QUEUE). Key changes: Refactored C++ code to use conditional logic that enables capabilities based on object type Updated test to verify at least one capability is enabled rather than requiring all capabilities Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Enable TAM type capability based on its type
Why I did it
The previous implementation was ambiguous
How I verified it
Check Azp
Details if related