Add drop monitor attributes to supported debug counter attributes#4120
Merged
prsunny merged 1 commit intosonic-net:masterfrom Jan 23, 2026
Merged
Conversation
The drop monitor feature introduced new CONFIG_DB fields drop_monitor_status, drop_count_threshold, incident_count_threshold and window for drop monitoring configuration. However, these attributes were not added to the supported_debug_counter_attributes set, causing error logs during debug counter installation: "Unknown debug counter attribute 'drop_monitor_status'" Add the missing drop monitor attribute definitions to debug_counter.h and include them in the supported attributes set in debug_counter.cpp. Signed-off-by: manish1 <manish1@arista.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@manish1-arista , can you link the HLD here? Also, is it backward compatible if some platforms doesn't support this new attributes? |
Contributor
Author
This is a fix for a bug introduced in PR #3509, so there is no new HLD. |
Contributor
|
@prsunny could you help to review again? |
prsunny
approved these changes
Jan 23, 2026
ganglyu
pushed a commit
to ganglyu/sonic-swss
that referenced
this pull request
Jan 26, 2026
…nic-net#4120) What I did Add the missing drop monitor attribute definitions to debug_counter.h and include them in the supported attributes set in debug_counter.cpp. Why I did it The drop monitor feature introduced new CONFIG_DB fields drop_monitor_status, drop_count_threshold, incident_count_threshold and window for drop monitoring configuration. However, these attributes were not added to the supported_debug_counter_attributes set, causing error logs during debug counter installation: "Unknown debug counter attribute 'drop_monitor_status'" It can replicated by running the test_configurable_drop_counters.py testcase which will fail in teardown with this error. How I verified it Verified the fix by running test_configurable_drop_counters.py which was previously failing in teardown with the error "Unknown debug counter attribute 'drop_monitor_status'". After applying the fix, the test passes without generating any error logs Signed-off-by: ganglyu <glv@nvidia.com>
ypcisco
pushed a commit
to ypcisco/sonic-swss
that referenced
this pull request
Jan 29, 2026
…nic-net#4120) What I did Add the missing drop monitor attribute definitions to debug_counter.h and include them in the supported attributes set in debug_counter.cpp. Why I did it The drop monitor feature introduced new CONFIG_DB fields drop_monitor_status, drop_count_threshold, incident_count_threshold and window for drop monitoring configuration. However, these attributes were not added to the supported_debug_counter_attributes set, causing error logs during debug counter installation: "Unknown debug counter attribute 'drop_monitor_status'" It can replicated by running the test_configurable_drop_counters.py testcase which will fail in teardown with this error. How I verified it Verified the fix by running test_configurable_drop_counters.py which was previously failing in teardown with the error "Unknown debug counter attribute 'drop_monitor_status'". After applying the fix, the test passes without generating any error logs Signed-off-by: Yash Pandit <ypcisco@gmail.com>
ksravani-hcl
pushed a commit
to ksravani-hcl/sonic-swss
that referenced
this pull request
Feb 20, 2026
…nic-net#4120) What I did Add the missing drop monitor attribute definitions to debug_counter.h and include them in the supported attributes set in debug_counter.cpp. Why I did it The drop monitor feature introduced new CONFIG_DB fields drop_monitor_status, drop_count_threshold, incident_count_threshold and window for drop monitoring configuration. However, these attributes were not added to the supported_debug_counter_attributes set, causing error logs during debug counter installation: "Unknown debug counter attribute 'drop_monitor_status'" It can replicated by running the test_configurable_drop_counters.py testcase which will fail in teardown with this error. How I verified it Verified the fix by running test_configurable_drop_counters.py which was previously failing in teardown with the error "Unknown debug counter attribute 'drop_monitor_status'". After applying the fix, the test passes without generating any error logs
Contributor
Author
|
@prsunny Needs to be cherry picked for 202511 |
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
…nic-net#4120) What I did Add the missing drop monitor attribute definitions to debug_counter.h and include them in the supported attributes set in debug_counter.cpp. Why I did it The drop monitor feature introduced new CONFIG_DB fields drop_monitor_status, drop_count_threshold, incident_count_threshold and window for drop monitoring configuration. However, these attributes were not added to the supported_debug_counter_attributes set, causing error logs during debug counter installation: "Unknown debug counter attribute 'drop_monitor_status'" It can replicated by running the test_configurable_drop_counters.py testcase which will fail in teardown with this error. How I verified it Verified the fix by running test_configurable_drop_counters.py which was previously failing in teardown with the error "Unknown debug counter attribute 'drop_monitor_status'". After applying the fix, the test passes without generating any error logs Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
ksravani-hcl
pushed a commit
to ksravani-hcl/sonic-swss
that referenced
this pull request
Feb 26, 2026
…nic-net#4120) What I did Add the missing drop monitor attribute definitions to debug_counter.h and include them in the supported attributes set in debug_counter.cpp. Why I did it The drop monitor feature introduced new CONFIG_DB fields drop_monitor_status, drop_count_threshold, incident_count_threshold and window for drop monitoring configuration. However, these attributes were not added to the supported_debug_counter_attributes set, causing error logs during debug counter installation: "Unknown debug counter attribute 'drop_monitor_status'" It can replicated by running the test_configurable_drop_counters.py testcase which will fail in teardown with this error. How I verified it Verified the fix by running test_configurable_drop_counters.py which was previously failing in teardown with the error "Unknown debug counter attribute 'drop_monitor_status'". After applying the fix, the test passes without generating any error logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add the missing drop monitor attribute definitions to debug_counter.h and include them in the supported attributes set in debug_counter.cpp.
Why I did it
The drop monitor feature introduced new CONFIG_DB fields drop_monitor_status, drop_count_threshold, incident_count_threshold and window for drop monitoring configuration. However, these attributes were not added to the supported_debug_counter_attributes set, causing error logs during debug counter installation:
"Unknown debug counter attribute 'drop_monitor_status'"It can replicated by running the
test_configurable_drop_counters.pytestcase which will fail in teardown with this error.How I verified it
Verified the fix by running test_configurable_drop_counters.py which was previously failing in teardown with the error "Unknown debug counter attribute 'drop_monitor_status'". After applying the fix, the test passes without generating any error logs
Details if related