[countersyncd]: Fix cargo bench compiling error#4204
Merged
prsunny merged 2 commits intosonic-net:masterfrom Feb 10, 2026
Merged
[countersyncd]: Fix cargo bench compiling error#4204prsunny merged 2 commits intosonic-net:masterfrom
prsunny merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Ze Gan <ganze718@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Fixes a build break in countersyncd benchmarks by updating OtelActorConfig initializations to match the current struct definition (removing a deprecated field), ensuring cargo bench compiles successfully.
Changes:
- Removed the deprecated
print_to_consolefield fromOtelActorConfiginitializers in benchmark code. - Restored compatibility of
crates/countersyncd/benches/*with the currentOtelActorConfigAPI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/countersyncd/benches/otel_actor_perf.rs | Removes deprecated print_to_console from OtelActorConfig init so the bench compiles. |
| crates/countersyncd/benches/end_to_end.rs | Removes deprecated print_to_console from OtelActorConfig init so the bench compiles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prsunny
approved these changes
Feb 9, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-swss.msft#207 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
jithenderkondam
pushed a commit
to jithenderkondam/sonic-swss
that referenced
this pull request
Feb 17, 2026
What I did Remove deprecated parameters. Why I did it The parameter, print_to_console, has been removed, but the CI will not run any bench program, so this error was ignored.
ksravani-hcl
pushed a commit
to ksravani-hcl/sonic-swss
that referenced
this pull request
Feb 20, 2026
What I did Remove deprecated parameters. Why I did it The parameter, print_to_console, has been removed, but the CI will not run any bench program, so this error was ignored.
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
What I did Remove deprecated parameters. Why I did it The parameter, print_to_console, has been removed, but the CI will not run any bench program, so this error was ignored. Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
ksravani-hcl
pushed a commit
to ksravani-hcl/sonic-swss
that referenced
this pull request
Feb 24, 2026
What I did Remove deprecated parameters. Why I did it The parameter, print_to_console, has been removed, but the CI will not run any bench program, so this error was ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Remove deprecated parameters.
Why I did it
The parameter, print_to_console, has been removed, but the CI will not run any bench program, so this error was ignored.
How I verified it
Run cargo locally
Details if related