[action] [PR:4197] [countersyncd]: Modify the exit behavior of the main function#4225
Open
mssonicbld wants to merge 1 commit intosonic-net:202511from
Open
[action] [PR:4197] [countersyncd]: Modify the exit behavior of the main function#4225mssonicbld wants to merge 1 commit intosonic-net:202511from
mssonicbld wants to merge 1 commit intosonic-net:202511from
Conversation
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** The main function exits as soon as any actor terminates. **Why I did it** Otel actor may terminate due to failed to connect the otel collector. In the previous behavior, the main function will not exit because it's waiting for all actor terminating. **How I verified it** Check it locally: ``` [2026-02-04 11:16:01.248] [crates/countersyncd/src/actor/otel.rs:340] [WARN] Export attempt 29 failed: status: Unavailable, message: "tcp connect error", details: [], metadata: MetadataMap { headers: {} } [2026-02-04 11:16:11.253] [crates/countersyncd/src/actor/otel.rs:340] [WARN] Export attempt 30 failed: status: Unavailable, message: "tcp connect error", details: [], metadata: MetadataMap { headers: {} } [2026-02-04 11:16:21.255] [crates/countersyncd/src/actor/otel.rs:405] [ERROR] Failed to export buffered metrics (consecutive failures 30): OtelActorExportError("Max export retries exceeded") [2026-02-04 11:16:21.256] [crates/countersyncd/src/actor/otel.rs:431] [INFO] Shutting down OtelActor... [2026-02-04 11:16:22.257] [crates/countersyncd/src/actor/otel.rs:439] [INFO] OtelActor shutdown complete. 2339 messages, 0 exports, 1 failures [2026-02-04 11:16:22.257] [crates/countersyncd/src/main.rs:421] [INFO] OpenTelemetry actor terminated [2026-02-04 11:16:22.257] [crates/countersyncd/src/main.rs:464] [ERROR] OpenTelemetry actor failed: OtelActorExportError("Max export retries exceeded") ``` **Details if related**
Collaborator
Author
|
Original PR: #4197 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Commenter does not have sufficient privileges for PR 4225 in repo sonic-net/sonic-swss |
Contributor
|
/azpw run |
Collaborator
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The main function exits as soon as any actor terminates.
Why I did it
Otel actor may terminate due to failed to connect the otel collector. In the previous behavior, the main function will not exit because it's waiting for all actor terminating.
How I verified it
Check it locally:
Details if related