Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Fix testdata file name invalid in windows OS #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix testdata file name invalid in windows OS #16

wants to merge 1 commit into from

Conversation

liuqu
Copy link

@liuqu liuqu commented Sep 6, 2018

The textdata files' name include ':' which is invalid symbol for file name in windows OS.
Replace ':' with '_' for testdata file name.

jipanyang
jipanyang approved these changes Sep 6, 2018
View reviewed changes
Copy link
Collaborator

@jipanyang jipanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Question to repo host, when could the auto-test gatekeeper be enabled as part of the checks?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jipanyang jipanyang jipanyang approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuqu @jipanyang