Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Fix Dial-out Insecure Mode #41

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

TildenWinston
Copy link

Adds support for insecure mode for testing and development purposes to telemetry dial-out. Based on the changes authored by @liuqu in PR #14 .
Previously -insecure failed to connect to collectors running on windows systems, but this fixes this issue.

Dial-out client: Fixes insecure mode

  • Fixes insecure mode
  • adds skip_verify flag

@ghost
Copy link

ghost commented Aug 3, 2020

CLA assistant check
All CLA requirements met.

@TildenWinston TildenWinston marked this pull request as ready for review August 3, 2020 17:45
@hui-ma
Copy link
Collaborator

hui-ma commented Aug 13, 2020

what test have been conducted for this change? And does all utest still work?

Insecure flag has been reverted back to corresponding with tlsCfg.InsecureSkipVerify and created a new flag, "tls_disable" for the new tlsDisable option.
Fixing sample collector code. Missed declaration, missed exclamation point.
@TildenWinston
Copy link
Author

how to config config DB to enable new flag or the new flag should not be enabled in config DB as all?

The change is to the command line arguments only. The change is not reflected in the CONFIG_DB. See #43 which is a new PR to add documentation for the command line arguments for more information.

@TildenWinston
Copy link
Author

what test have been conducted for this change? And does all utest still work?

I was unable to unit tests working with or without this update. I have tested manually.
image

Manual tests include:
Dev VM to C# Collector (Both secure and insecure)
Tested as an additional service on real SONiC device to C# Collector (Secure)
Dev VM to Golang Dial-out collector (Insecure, Insecure with tls_disable on both sides, Secure)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants