[show][interface][counters] Add proposal and changes for fec-histogram for interface counters fec-histogram subcommand #3519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for show int counters fec-histogram subcommand Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
prgeor
reviewed
Sep 9, 2024
vdahiya12
changed the title
Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
prgeor
approved these changes
Sep 10, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Sep 20, 2024
…m for interface counters fec-histogram subcommand (sonic-net#3519) * [show][interface][counters] Add proposal and changes for fec-histogram for show int counters fec-histogram subcommand Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add implementation Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add changes Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add changes Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add UT Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * fix test Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * correct doc Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add changes Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add cosmetic fix Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add fixes Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * pep 8 Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add indentation Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> --------- Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
|
Cherry-pick PR to 202405: #3551 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 20, 2024
…m for interface counters fec-histogram subcommand (#3519) * [show][interface][counters] Add proposal and changes for fec-histogram for show int counters fec-histogram subcommand Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add implementation Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add changes Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add changes Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add UT Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * fix test Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * correct doc Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add changes Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add cosmetic fix Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add fixes Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * pep 8 Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> * add indentation Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com> --------- Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This pull request proposes the addition of a new command line subcommand, show interfaces counters fec-histogram, to monitoring network interfaces. This new command is designed to display the FEC (Forward Error Correction) histogram for a specified port.
Summary of Changes:
New Subcommand: show interfaces counters fec-histogram [<interface_name>]
Output: A table showing the number of codewords in each error bin, with bins labeled as BIN_FEC_CODEWORD_S0 through BIN_FEC_CODEWORD_S16.
This new command will help network administrators diagnose and monitor the health of network links by providing insights into the distribution of error correction activities across different levels of severity.
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)