Z-score Threshold tutorial #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad-c
requested changes
Mar 21, 2024
| "outputs": [], | ||
| "source": [ | ||
| "#print layer name\n", | ||
| "for index, layer in enumerate(float_model.layers):\n", |
There was a problem hiding this comment.
wouldn't print(float_model.layers[51].name) do the trick?
There was a problem hiding this comment.
Hey, This particular layer is i believe an added quantise layer so the name does not match up directly to layer names in keras. I have added some code used to find this in the appendix. I will keep this as it is unless you feel otherwise.
There was a problem hiding this comment.
sorry, miss read your original comment. fixed
| "To calculate a threshold $t$ for quantization based on a Z-score threshold $Z_t$, you might define $t$ as a function of $Z_t$, $\\mu$, and $\\sigma$, such as:\n", | ||
| "\n", | ||
| "$$\n", | ||
| "t(Zt)=\\frac{μ+Zt⋅σ}{μ+Zt⋅σ}\n", |
There was a problem hiding this comment.
isn't this just \\frac{μ+Zt⋅σ}{μ+Zt⋅σ} = 1?
There was a problem hiding this comment.
nice spot, not sure why i left the fraction in there
|
made all the relevant changes @elad-c thanks for feed back |
elad-c
approved these changes
Mar 27, 2024
| "outputs": [], | ||
| "source": [ | ||
| "#print layer name\n", | ||
| "for index, layer in enumerate(float_model.layers):\n", |
elad-c
approved these changes
Mar 27, 2024
samuel-wj-chapman
added a commit
to samuel-wj-chapman/model_optimization
that referenced
this pull request
Apr 8, 2024
addition of zscore mct tutorial including updates to tutorial utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
notebook tutorial guiding the user through the use of z-score and its affect on quantisation thresholds and accuracy
Checklist before requesting a review: