Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch for release 2.0 #1023

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Conversation

Idan-BenAmi
Copy link
Collaborator

@Idan-BenAmi Idan-BenAmi commented Mar 31, 2024

Pull Request Description:

Updates for release 2.0.0
https://idan-benami.github.io/model_optimization/docs/index.html

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Copy link
Collaborator

@ofirgo ofirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the file because its only a name change but regarding the FolderImageLoader:

  • First of all, I think it should have been removed
  • If not, I don't understand the name change

@Idan-BenAmi Idan-BenAmi merged commit f3bbdac into sony:main Apr 1, 2024
27 checks passed
samuel-wj-chapman pushed a commit to samuel-wj-chapman/model_optimization that referenced this pull request Apr 8, 2024
* Update docs and version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants