Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activation gradient backprop in GPTQ #1197

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Fix activation gradient backprop in GPTQ #1197

merged 2 commits into from
Sep 8, 2024

Conversation

irenaby
Copy link
Collaborator

@irenaby irenaby commented Sep 1, 2024

Pull Request Description:

Add freeze_quant_params flag to base trainable quantizer with False as default.
Implement quant params freezing for STE activation quantizers.
Use activation trainable quantizers in GPTQ instead of inferable quantizers, with frozen quant params.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@irenaby irenaby marked this pull request as ready for review September 4, 2024 07:50
@irenaby irenaby merged commit 75e9f83 into main Sep 8, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants