Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CoreConfig and its inner configs to be dataclasses #1203

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

ofirgo
Copy link
Collaborator

@ofirgo ofirgo commented Sep 8, 2024

Pull Request Description:

Conver the following configuration classes to dataclasses and fix some misalignments in those classes: CoreConfig, QuantizationConfig, MixedPrecisionQuantizationConfig, DebugConfig, BitWidthConfig.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@ofirgo ofirgo marked this pull request as draft September 8, 2024 11:25
@ofirgo ofirgo requested a review from irenaby September 9, 2024 05:04
@ofirgo ofirgo marked this pull request as ready for review September 9, 2024 05:04
…d_precision_enable to is_mixed_precision_enabled
@ofirgo ofirgo requested a review from irenaby September 10, 2024 07:50
@ofirgo ofirgo merged commit 95f65ea into sony:main Sep 11, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants