Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphBuilder - verify node name is not reserved method of nn.module #1204

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Idan-BenAmi
Copy link
Collaborator

Pull Request Description:

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@ofirgo ofirgo marked this pull request as draft September 10, 2024 07:50
@Idan-BenAmi Idan-BenAmi mentioned this pull request Sep 10, 2024
9 tasks
@Idan-BenAmi
Copy link
Collaborator Author

This PR intends to rename reserved name of node on the Graph such as "to" in order to avoid confusion between node of the output model and the PyTorch operation "to".
We still consider if the operation "to" as part of input model is valid MCT input, therefore, setting this PR to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant