Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials license #1220

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Tutorials license #1220

merged 6 commits into from
Sep 17, 2024

Conversation

Idan-BenAmi
Copy link
Collaborator

@Idan-BenAmi Idan-BenAmi commented Sep 17, 2024

Pull Request Description:

Update license and copyright in the tutorials code

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@@ -284,6 +285,9 @@ def nodes_builder(model: GraphModule,
graph_node_type = BaseNode
kwargs = {}

if node.name == RESERVED_NAME_TO:
node.name = node.name + RESERVED_NAME_SUFFIX
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be in a different PR?

You should also get your employer (if you work as a programmer) or school,
if any, to sign a "copyright disclaimer" for the program, if necessary.
For more information on this, and how to apply and follow the GNU AGPL, see
<https://www.gnu.org/licenses/>.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Copyright (C) 2024 Ultralytics

Main changes:
Modify layers to make them more suitable for quantization
torch.fx compatibility
Detect head (mainly the box decoding part that was optimized for model quantization)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Indentation

solutions will be better for different programs; see section 13 for the
specific requirements.

You should also get your employer (if you work as a programmer) or school,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Copyright (C) 2024 Ultralytics

@Idan-BenAmi Idan-BenAmi merged commit 32bce48 into sony:main Sep 17, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants