Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TF 2.15 #993

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Support TF 2.15 #993

merged 2 commits into from
Mar 14, 2024

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented Mar 12, 2024

Pull Request Description:

This PR add support for TF 2.15 to MCT. The breaking change in this TF version is the function that the TFOpLambda layer holds in its function attribute. For example, before 2.15, if TFOpLambda holds a tf.add function, then the actual function in the function attribute is different than tf.add, and that messes things up.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@ofirgo
Copy link
Collaborator

ofirgo commented Mar 13, 2024

Can you please add a brief description to the PR specifying what were "breaking changes" that affected the MCT and what is the solution for them? just so we'll know what to look for in the review

@elad-c elad-c merged commit 539b592 into main Mar 14, 2024
27 checks passed
@elad-c elad-c deleted the support_tf_215 branch March 14, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants