Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change of moving kpi_target from facades, and ser default MP config in CoreConfig #996

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

ofirgo
Copy link
Collaborator

@ofirgo ofirgo commented Mar 14, 2024

Pull Request Description:

MP run is decided based on initialized target_kpi.
CoreConfig holds a default MP config anyway to allow MP execution if desired.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@ofirgo ofirgo merged commit 3065778 into sony:main Mar 17, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants