Populate __version__ for nightly builds
#999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old timestamp created what PEP 440 calls an [implicit post-release](https://peps.python.org/pep-0440/#implicit-post-releases), the trailing `-hhmmss` portion is converted to `.posthhmmss` with leading zeros omitted, usually resulting in a 3-digit post-release identifier on PyPI because the build takes a few minutes and starts close to midnight.
reuvenperetz
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Closes #998.
This changeset modifies the nightly build workflow to set
model_compression_toolkit.__version__in-source, making the full nightly version identifier available at runtime. This also resolves the curious post-release identifiers published to PyPI, which I assume were unintentional behavior (please correct me if I'm wrong).