Skip to content

fix (semantics) of MutableStmtGraph.insertBefore(Stmt existingStmt, FallsThroughStmt newStmt) #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
swissiety opened this issue Feb 27, 2024 · 0 comments · Fixed by #1141
Closed
2 tasks
Assignees

Comments

@swissiety
Copy link
Collaborator

https://github.com/soot-oss/SootUp/pull/869/files#diff-c5721a80c02fabaa342480b1e4d00ff3269aa3bc5ca20c721c4d30c0ad3fac75R87
suggests that something is wrong with insertBefore(...).

semantic options:
a) All (Branching-) predecessors of existingStmt would flow to the newStmt and then it goes to the existingStmt.
b) inserts a newStmt in the FallsThrough flow but not in the predecessor flows branching to the oldStmt.

  • it seems a) is more intuitive for insertBefore(...)
  • and an easier option for b) than: removeEdge(...), putEdge(...) etc. should exist as well.
@wangzun66 wangzun66 self-assigned this Nov 7, 2024
@wangzun66 wangzun66 linked a pull request Nov 14, 2024 that will close this issue
4 tasks
@wangzun66 wangzun66 linked a pull request Nov 28, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants