Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix insertBefore #1130

Closed
wants to merge 1 commit into from
Closed

fix insertBefore #1130

wants to merge 1 commit into from

Conversation

wangzun66
Copy link
Collaborator

@wangzun66 wangzun66 commented Nov 14, 2024 •
edited
Loading

  • P1: After insertion, Blocks are not merged.
  • P2: After insertion, Information of Traps may be false.
  • P3: Sometimes(maybe with traps), a block could have two same predecessors.
  • P4: Sometimes(maybe with traps), a block could be itself's predecessor.

@wangzun66 wangzun66 self-assigned this Nov 14, 2024
@wangzun66 wangzun66 linked an issue Nov 14, 2024 that may be closed by this pull request
fix (semantics) of MutableStmtGraph.insertBefore(Stmt existingStmt, FallsThroughStmt newStmt) #873
Closed
2 tasks
@swissiety swissiety marked this pull request as draft November 14, 2024 12:20
@wangzun66 wangzun66 closed this Nov 28, 2024
@wangzun66 wangzun66 deleted the fix_insert_before branch January 9, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wangzun66 wangzun66

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix (semantics) of MutableStmtGraph.insertBefore(Stmt existingStmt, FallsThroughStmt newStmt)
1 participant
@wangzun66