Skip to content

Commit

Permalink
readme: update line numbers for webhook permission check
Browse files Browse the repository at this point in the history
In the future, the readme probably should use an alternate means of
indicating why these are necessary, because this link is very fragile.
Either we start referencing a specific code revision (thus potentially
linking to very outdated code, over time), or we stop linking from
documentation into the code like this entirely.
  • Loading branch information
dgw committed Feb 9, 2019
1 parent 7ba3772 commit 16e6f13
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ external_url = http://your.ip.here:3333/webhook

### Creating hooks

As an OP+ in a channel, you may type `.gh-hook user/repo`. You will see some informational text on what you need to do to finalize the hook, including a link to click to authorize the creation of the webhook. You will be required to authorize the Github application to read/write your webhooks (see [L167-168](https://github.com/sopel-irc/sopel-github/blob/master/sopel_modules/github/webhook.py#L167-L168)) but this should be the _only_ permissions we need.
As an OP+ in a channel, you may type `.gh-hook user/repo`. You will see some informational text on what you need to do to finalize the hook, including a link to click to authorize the creation of the webhook. You will be required to authorize the Github application to read/write your webhooks (see [L163-164](https://github.com/sopel-irc/sopel-github/blob/master/sopel_modules/github/webhook.py#L163-L164)) but this should be the _only_ permissions we need.

```
<@maxpowa> .gh-hook maxpowa/sopel-github
Expand Down

0 comments on commit 16e6f13

Please sign in to comment.