fix(Dialog): Dialog onClick 이벤트 이슈 수정 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brokyeom
requested review from
sohee-K,
jungwoo3490 and
suwonthugger
as code owners
🦋 Changeset detectedLatest commit: e2a00fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Brokyeom
changed the title
Brokyeom
commented
Sep 23, 2024
| @@ -14,66 +14,56 @@ export default function DialogComponent({ | |||
| typeOptions, | |||
| }: DialogValueProps) { | |||
| const onApprove = () => { | |||
| typeOptions?.buttonFunction; | |||
| typeOptions?.buttonFunction && typeOptions.buttonFunction(); | |||
| @@ -21,6 +21,7 @@ export const overlay = style({ | |||
| alignItems: 'center', | |||
| justifyContent: 'center', | |||
| backgroundColor: theme.colors.backgroundDimmed, | |||
| zIndex: 999, | |||
There was a problem hiding this comment.
일단 임의로 넣었는데요, 나중에 mds가 많이 정착되면 zIndex 컨벤션도 만드는게 좋을 것 같습니다.
Brokyeom
commented
Sep 23, 2024
| <CheckBox | ||
| checked={checkBoxOptions.checked} | ||
| color={checkBoxOptions.color} | ||
| label={checkBoxOptions.label} | ||
| onChange={checkBoxOptions.onChange} | ||
| size={checkBoxOptions.size ?? 'small'} | ||
| size={checkBoxOptions.size ?? 'sm'} |
There was a problem hiding this comment.
size spec이 small -> sm 으로 바뀐게 적용이 안되어 수정 해 주었습니다.
suwonthugger
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
링크
시급한 정도
🏃♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.
기타 사항
AS-IS
TO-BE
2024-09-22.3.30.45.mov