-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dialog): Dialog onClick 이벤트 이슈 수정 #145
Conversation
🦋 Changeset detectedLatest commit: e2a00fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -14,66 +14,56 @@ export default function DialogComponent({ | |||
typeOptions, | |||
}: DialogValueProps) { | |||
const onApprove = () => { | |||
typeOptions?.buttonFunction; | |||
typeOptions?.buttonFunction && typeOptions.buttonFunction(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경된 부분
@@ -21,6 +21,7 @@ export const overlay = style({ | |||
alignItems: 'center', | |||
justifyContent: 'center', | |||
backgroundColor: theme.colors.backgroundDimmed, | |||
zIndex: 999, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 임의로 넣었는데요, 나중에 mds가 많이 정착되면 zIndex 컨벤션도 만드는게 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다~
<CheckBox | ||
checked={checkBoxOptions.checked} | ||
color={checkBoxOptions.color} | ||
label={checkBoxOptions.label} | ||
onChange={checkBoxOptions.onChange} | ||
size={checkBoxOptions.size ?? 'small'} | ||
size={checkBoxOptions.size ?? 'sm'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size spec이 small -> sm
으로 바뀐게 적용이 안되어 수정 해 주었습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
문의 사항 빠르게 수정하시느라 고생 많으셨습니다! typeOptions 처럼 사용하는 방식이 생소한데, 신기하네요! 굿굿
변경사항
링크
시급한 정도
🏃♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.
기타 사항
AS-IS
TO-BE
2024-09-22.3.30.45.mov