Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): 서브 컴포넌트 사용 케이스를 나누어 스토리북 작성 #149

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

suwonthugger
Copy link
Member

@suwonthugger suwonthugger commented Sep 25, 2024

변경사항

링크

https://sopt-makers.slack.com/archives/C07AFHC6LDB/p1727270019264379?thread_ts=1727269906.082949&cid=C07AFHC6LDB

시급한 정도

🏃‍♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.

기타 사항

  • 스토리북은 배포된 makers npm 패키지로 작성되어 있어, SelectV2를 사용하기 위해 packege.json에서 makers/ui 버전을 2.3.0으로 수정했어요.

  • 기존 Select의 스토리북 경로를 deprecated로 이동 했어요.

  • TriggerContent 사용 여부에 따라 두개로 케이스를 나누어 간단하게 스토리를 작성했습니다.

  • 자세한 경로는 아래와 같습니다.

image
new-select-stories.mov
new-select-stories2.mov

Copy link

height bot commented Sep 25, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: 86eb915

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@Brokyeom Brokyeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다. bump는 patch로 갈게요! 늦은시간인데 고생 많았어요 ㄷㄷ


const meta = {
title: "Components/Input/Select",
title: 'Components/Input/deprecated/Select',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존 Select 스토리북 경로 수정된 부분이에요.

Comment on lines +56 to +58
<div>
<IconDotsVertical style={style} />
</div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TriggerContent를 쓰지 않는 케이스의 경우, Trigger의 자식요소로 mds 요청에서 문의 주셨던 아이콘을 넣어놨어요.

@jungwoo3490
Copy link
Member

LGTM

@suwonthugger
Copy link
Member Author

스토리북 배포도 완료했습니다!
https://6571c88390d085ed7efcce84-uowioajvxk.chromatic.com/

@Brokyeom Brokyeom merged commit bafb50f into main Sep 25, 2024
2 of 3 checks passed
@Brokyeom Brokyeom deleted the feat/#148/select-v2-storybook branch September 25, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants