-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Skeleton 컴포넌트 구현 #178
Conversation
|
🦋 Changeset detectedLatest commit: 9b97c0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
추후에 스토리북이랑 컴포넌트 이렇게 설명 추가해나가면 좋을것 같아요 고생하셨어요!
circular: '100%', | ||
rounded: '100%', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variant가 circular
인 case와 rounded
인 case의 차이가 있을까요?? 지금 variant로 분기되는 스타일이 radius밖에 없어보이는데, 두 case의 radius 값이 동일해서 혹시 다른 차이가 있는지 궁금해요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cricular
: 높이, 너비가 같은 원형
rounded
: 높이, 너비가 다를 경우에 사용되는 스타일 (e.g. button rounded lg)
의 용도로 구분해두긴 했습니다. (레퍼런스)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추후에 variant 에 따라서 스타일이 달리질 것을 염두해서 분리해두려는 목적도 있습니다!
변경사항
prop 정보는 아래와 같습니다
링크
시급한 정도
🏃♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.
기타 사항