Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] 알림 발송 API 연결 #116

Merged
merged 14 commits into from
Oct 26, 2024
Merged

Conversation

Brokyeom
Copy link
Member

@Brokyeom Brokyeom commented Oct 13, 2024

✨ 구현 기능 명세

✅ PR Point

  • 기존에 selectOption을 삭제하고 utils로 모든 유틸 함수, 상수를 옮겼어요.
  • 현재 알림 수신쪽에 문제가 있는 것으로 해당 스레드에서 공유드렸는데, 작업이 더 딜레이 되는 것을 방지하고자 일단 open 합니다!

😭 어려웠던 점

  • api 명세가 없더라구요..? 그래서 동규랑 해커톤 한것도 있습니다.

Copy link

height bot commented Oct 13, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

cloudflare-workers-and-pages bot commented Oct 13, 2024

Deploying sopt-admin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 16726b3
Status: ✅  Deploy successful!
Preview URL: https://c6416b5b.sopt-admin.pages.dev
Branch Preview URL: https://feature-alarm-api.sopt-admin.pages.dev

View logs

@Brokyeom Brokyeom changed the base branch from dev to feature-alarm_modal October 13, 2024 15:24
@Brokyeom Brokyeom changed the title Feature alarm api [Feature] 알림 발송 API 연결 Oct 14, 2024
@Brokyeom Brokyeom changed the title [Feature] 알림 발송 API 연결 [FEATURE] 알림 발송 API 연결 Oct 15, 2024
@Brokyeom Brokyeom self-assigned this Oct 16, 2024
@Brokyeom Brokyeom marked this pull request as ready for review October 16, 2024 10:02
Copy link
Member

@jungwoo3490 jungwoo3490 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많았어요!!! 코멘트 한 번 확인해주세요 :)

src/components/alarmAdmin/CreateAlarmModal/style.ts Outdated Show resolved Hide resolved
Comment on lines -73 to -88
{ label: '00:00', value: '00:00' },
{ label: '00:30', value: '00:30' },
{ label: '01:00', value: '01:00' },
{ label: '01:30', value: '01:30' },
{ label: '02:00', value: '02:00' },
{ label: '02:30', value: '02:30' },
{ label: '03:00', value: '03:00' },
{ label: '03:30', value: '03:30' },
{ label: '04:00', value: '04:00' },
{ label: '04:30', value: '04:30' },
{ label: '05:00', value: '05:00' },
{ label: '05:30', value: '05:30' },
{ label: '06:00', value: '06:00' },
{ label: '06:30', value: '06:30' },
{ label: '07:00', value: '07:00' },
{ label: '07:30', value: '07:30' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 제거하는 걸로 디자이너 선생님들과 얘기가 된 부분일까요?!?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/components/alarmAdmin/CreateAlarmModal/index.tsx Outdated Show resolved Hide resolved
jungwoo3490
jungwoo3490 approved these changes Oct 24, 2024
@jungwoo3490 jungwoo3490 self-requested a review October 24, 2024 17:53
Copy link
Member

@jungwoo3490 jungwoo3490 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정사항 확인했습니다!!
고생 많았어요!!! 🚀🚀

@Brokyeom Brokyeom merged commit 59a0024 into feature-alarm_modal Oct 26, 2024
1 check passed
Brokyeom added a commit that referenced this pull request Nov 2, 2024
* feat: 알림 발송 Modal UI 구현

* fix: description 필드 제거

* fix: resolve build error

* chore: set yarn 4.5.0

* feat: 알림 발송 API 연결

* Revert "feat: 알림 발송 API 연결"

This reverts commit d25d07e.

* Revert "chore: set yarn 4.5.0"

This reverts commit e931706.

* fix: DatePicker용 커스텀 Select 컴포넌트로 대체

* [FEATURE] 알림 발송 API 연결 (#116)

* yarn install version 4.5.0

* Revert "feat: 알림 발송 API 연결"

This reverts commit d25d07e.

* feat: 알림 발송 API 연결

* fix: remoce legacy postAlarm function.

* fix: remove legacy Alarm Modal component.

* feat: 알림 앱링크 연결

* refactor: selectOptions 항목 utils로 이동

* lint

* feat: CSV 파일 업로드 로직 이식

* fix: 불필요한 코드 삭제

* feat: CSV 파일 검사 로직 추가

* Add onClose

* fix: csv 조건문 수정

* update cache

* fix: 발송금지시간 스펙 변경사항 반영

---------

Co-authored-by: Brokyeom <goindol40@gmail.com>
Co-authored-by: HyeongKyeom Kim <97586683+Brokyeom@users.noreply.github.com>
Brokyeom added a commit that referenced this pull request Nov 29, 2024
* [FEATURE] 알림 발송 Modal 구현 (#115)

* feat: 알림 발송 Modal UI 구현

* fix: description 필드 제거

* fix: resolve build error

* chore: set yarn 4.5.0

* feat: 알림 발송 API 연결

* Revert "feat: 알림 발송 API 연결"

This reverts commit d25d07e.

* Revert "chore: set yarn 4.5.0"

This reverts commit e931706.

* fix: DatePicker용 커스텀 Select 컴포넌트로 대체

* [FEATURE] 알림 발송 API 연결 (#116)

* yarn install version 4.5.0

* Revert "feat: 알림 발송 API 연결"

This reverts commit d25d07e.

* feat: 알림 발송 API 연결

* fix: remoce legacy postAlarm function.

* fix: remove legacy Alarm Modal component.

* feat: 알림 앱링크 연결

* refactor: selectOptions 항목 utils로 이동

* lint

* feat: CSV 파일 업로드 로직 이식

* fix: 불필요한 코드 삭제

* feat: CSV 파일 검사 로직 추가

* Add onClose

* fix: csv 조건문 수정

* update cache

* fix: 발송금지시간 스펙 변경사항 반영

---------

Co-authored-by: Brokyeom <goindol40@gmail.com>
Co-authored-by: HyeongKyeom Kim <97586683+Brokyeom@users.noreply.github.com>

* style: nav, header 스타일 추가

* feat: 알림 리스트 query 수정

* feat: 알림 리스트 mds 적용 및 변경된 스펙 적용

* feat: 알림 조회 WIP

* feat: 알림 조회 링크 & 디자인 추가

* fix: line-height를 padding-top으로 대체

* fix: mds Chip으로 대체

* refact: utils 분리

* fix: Alarm type 수정

* Feat: Chip에 disabled 추가 (#158)

* chore: update mds version to 2.7.15

* feat: Chip에 disabled 추가

* resolve conflict

---------

Co-authored-by: Brokyeom <goindol40@gmail.com>

---------

Co-authored-by: Jungwoo LEE <jungwoo3490@naver.com>
Co-authored-by: sohee <soheek@fairsquarelab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants