Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] 소개탭, 지원하기탭 필수조건 에러처리 및 label 수정 #148

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

lydiacho
Copy link
Member

@lydiacho lydiacho commented Nov 27, 2024

✨ 구현 기능 명세

✅ PR Point

소개탭에 required 조건 추가 및 error 처리를 추가해주었어요.

그런데 errors 객체 사용하는 과정에서 제가 register label로 사용하던 방식(이전 PR 참고)이 타입에러를 발생시키더라구요.
빨간줄을 해결하기 위해서는 제가 사용했던 API 스키마와 동일한 구조가 될 수 있도록 FormValue 타입을 따로 선언해줘야 하는 것으로 보였는데,
현재는 그렇게 타입을 고도화할 시간이 없어서 일단 객체 구조였던 register label을 모두 flatten 시켜서 string화 해주었습니다.

제 컨벤션을 적용시켰던 지원하기 탭에서도, 언석오빠가 최초에 작업해주었던 isError 및 errorMessage가 다 정상작동 하고 있지 않더라구요
그래서 label 모두 flatten 시켜주고 errors 처리도 정상화시켜주었습니다.

2024-11-28.1.28.45.mov

@lydiacho lydiacho self-assigned this Nov 27, 2024
Copy link

height bot commented Nov 27, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@eonseok-jeon eonseok-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿~~

@eonseok-jeon eonseok-jeon merged commit 47dc07d into dev Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants