Refactor: 커피챗 오픈/수정 페이지 변경사항 적용 #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- chip -> dropwdown
- chip -> PC: dropdown, MO: bottomsheet 으로 변경
- MO에서 dropdown -> bottomsheet 으로 변경
|
|
🚀 프리뷰 배포 확인하기 🚀 |
seojisoosoo
approved these changes
Dec 16, 2024
Comment on lines
+40
to
+50
| useEffect(() => { | ||
| if (open) { | ||
| document.body.style.overflow = 'hidden'; | ||
| } else { | ||
| document.body.style.overflow = ''; | ||
| } | ||
|
|
||
| return () => { | ||
| document.body.style.overflow = ''; | ||
| }; | ||
| }, [open]); |
There was a problem hiding this comment.
q
요기 돔을 직접 조작하는 코드같은데, 이렇게 사용한 이유가 있는지 궁금해요!
There was a problem hiding this comment.
a
요기는 BottomSheet가 열리면 뒤 배경이 스크롤되지 않도록 추가해줬습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
🤔 그렇다면, 어떻게 구현했어요~?
mds의 BottomSheet 컴포넌트가 없어서
BottomSheetSelect를 구현했습니다.❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?
[PC]
[MO]