Skip to content

refactor: 커뮤니티 글쓰기 이미지 디바운싱 #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

seojisoosoo
Copy link
Member

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

  • 이미지 업로드 훅(커뮤니티 이미지 업로드, 프로젝트 이미지 업로드에 사용)에 디바운싱을 적용했어요.

🤔 그렇다면, 어떻게 구현했어요~?

  • 기존에 설치되어있던 lodash-es/debounce를 사용했어요.
  • 이미지 업로드 로직에 debounce를 감싸주었습니다.

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

  • 잘 한 게 맞나... 하는 의문이 들어서... 편하게 의견 주세요!!
  • 생각했던 것보다 이미지 미리보기가 뜨는 과정이 느리더라고요(기존부터). 이 부분은 로딩 추가하거나, 리사이징하는 로직 추가해보겠습니다..!

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

Copy link

height bot commented Dec 13, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@seojisoosoo seojisoosoo self-assigned this Dec 13, 2024
@github-actions github-actions bot requested a review from pepperdad December 13, 2024 13:59
Copy link

✨✨ 스토리북으로 확인하기 ✨✨

Copy link

🚀 프리뷰 배포 확인하기 🚀

https://d99159e9.sopt-internal-dev.pages.dev

Copy link
Member

@pepperdad pepperdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

지금 생각해보니 검색이나 좋아요처럼 이벤트가 자주 발생하는 게 아닌데,
이미지 디바운싱이 왜 필요한지를 고민해야 할 것 같네요...

@seojisoosoo seojisoosoo added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit ad956a2 Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: 이미지 디바운싱
2 participants