Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migration to polkadot sdk 1.1.0 #1144

Open
wants to merge 118 commits into
base: master
Choose a base branch
from
Open

Conversation

i3ima
Copy link
Contributor

@i3ima i3ima commented Jul 24, 2024

This is the tracking PR for the upgrade of polkadot-sdk.
At the moment I can recall of the following issues:

  • Some tests and benchmarks don't pass
  • Local paths are used in patch sections of workspace-level Cargo.toml (i.e you are forced to have cloned repos of dependencies one directory up)
  • Bunch of warnings, some of which can't be fixed by simple cargo fix -- It breaks things (I suspect it's because of procedural macros or other conditional items visibility problem)

Not so issues, but important notes:

  • This probably doesn't break anything but should be mentioned anyways. One of the packages that 1.1.0 uses is bandersnatch_vrfs (from ring-vrf ) which contains various important cryptography functions that are used in blocks production. It specifies this dependency via git repository and commit hash (3119f51). At this specific commit hash it causes compiler error because of broken Cargo.toml. So I decided to bump it
  • Test test_deposit_collateral_not_enough_balance of pallets/kensetsu/src/tests.rs changes expected error enumeration in which I'm unsure

The lists will be updated as we progress

@i3ima
Copy link
Contributor Author

i3ima commented Aug 26, 2024

Currently this PR is not fully ready for review as it's not very clean. Following things will be done next:

  • Cleanup rustc & clippy warnings
  • Test on predev

@wer1st wer1st added the breaks-API This tasks brings changes to the API; next release should be major. Notify builders/clients label Sep 27, 2024
@wer1st wer1st self-assigned this Oct 8, 2024
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
@wer1st wer1st removed their assignment Dec 7, 2024
@wer1st wer1st removed their request for review December 7, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks-API This tasks brings changes to the API; next release should be major. Notify builders/clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants