-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migration to polkadot sdk 1.1.0 #1144
Open
i3ima
wants to merge
118
commits into
master
Choose a base branch
from
polkadot_sdk_1.1.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So runtime will run after polkadot-sdk upgrade
…ne for assert_noop_msg
…ounts in some tests
Currently this PR is not fully ready for review as it's not very clean. Following things will be done next:
|
wer1st
added
the
breaks-API
This tasks brings changes to the API; next release should be major. Notify builders/clients
label
Sep 27, 2024
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Signed-off-by: Mikhail Tagirov <dev.mikhail.tagirov@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaks-API
This tasks brings changes to the API; next release should be major. Notify builders/clients
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the tracking PR for the upgrade of polkadot-sdk.
At the moment I can recall of the following issues:
Cargo.toml
(i.e you are forced to have cloned repos of dependencies one directory up)cargo fix
-- It breaks things (I suspect it's because of procedural macros or other conditional items visibility problem)Not so issues, but important notes:
bandersnatch_vrfs
(from ring-vrf ) which contains various important cryptography functions that are used in blocks production. It specifies this dependency via git repository and commit hash (3119f51
). At this specific commit hash it causes compiler error because of brokenCargo.toml
. So I decided to bump ittest_deposit_collateral_not_enough_balance
ofpallets/kensetsu/src/tests.rs
changes expected error enumeration in which I'm unsureThe lists will be updated as we progress