Avoid crashes on macOS by exec(2) after daemonize #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorah
force-pushed
the
fix-macos-crash
branch
from
5868138 to
2bb9158
Compare
We can encounter the following error if we continue without
re-exec(2)-ing:
objc[11602]: +[__NSCFConstantString initialize] may have been in
progress in another thread when fork() was called.
We cannot safely call it or ignore it in the fork() child process.
Crashing instead. Set a breakpoint on objc_initializeAfterForkError
to debug.
In Mairu's case, most these crashes are triggered in
a copy_certificates_from_keychain dispatch queue thread.
This is likely relevant to security-framework crate which utilise
Security.framework for TLS functionality, and appears to be difficult to
avoid; unforeseen risks remain ahead that could cause similar issues.
We're avoiding by re-exec(2)-ing itself to prevent the issue at all.
See also: https://www.sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html
sorah
force-pushed
the
fix-macos-crash
branch
from
2bb9158 to
6b5baee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can encounter the following error if we continue without re-exec(2)-ing:
In Mairu's case, most these crashes are triggered in a copy_certificates_from_keychain dispatch queue thread.
This is likely relevant to security-framework crate which utilise Security.framework for TLS functionality, and appears to be difficult to avoid; unforeseen risks remain ahead that could cause similar issues.
We're avoiding by re-exec(2)-ing itself to prevent the issue at all.
See also: https://www.sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html