Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving args to querystring #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

devnull
Copy link

@devnull devnull commented May 31, 2023

Rather than passing the arguments in the json payload, the arguments are instead included in the query string.

@sorenisanerd
Copy link
Owner

What's the motivation behind this change?

@devnull
Copy link
Author

devnull commented Jun 25, 2023

This allows the ability to dynamically adjust the arguments. In my case, i am proxying gotty and the websockets using AspNetProxy. I have a requirement to dynamically change the resulting command that is ultimately being called at the point of the proxy. When the command argument is encapsulated in the InitMessage, it’s not possible to change the content of the initmessage, but i could when it was made available in the query string.

@sorenisanerd
Copy link
Owner

I personally prefer the commands not being readily available in e.g. proxy logs, but I'm sympathetic to your use case. Can you make it optional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants