*: Have keeper notify when shutting down #845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rg2011
force-pushed
the
feature/keeper-notify-shutdown
branch
from
cf4b2ec
to
1fafdc3
Compare
rg2011
force-pushed
the
feature/keeper-notify-shutdown
branch
3 times, most recently
from
c2950b2
to
88b5832
Compare
Avoided race condition in sending dying gasp Renamed variable Fixed linting issue test: re-enable gofmt tests Enabled smart stop after dying gasp reordered pg close and dying gasp
rg2011
force-pushed
the
feature/keeper-notify-shutdown
branch
from
88b5832
to
c49cb02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix for issue #844: Have keeper notify sentinels when they are being shutdown via SIGTERM or SIGKILL.
This patch abuses the
Healthyflag in theKeeperInfo.PostgresStatestruct. This was done to avoid changes to the Sentinel.This patch also changes the default behaviour of the keeper, to send a dying gasp by default when shutdown. Someone might be relying on the current behaviour, for instance setting timers high enough to avoid a failover if the master restarts quickly.