-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support --wal-dir in keeper #865
Open
sebasmannem
wants to merge
6
commits into
sorintlab:master
Choose a base branch
from
sebasmannem:waldir
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Feb 18, 2022
-
For those who run Postgres with a WAL directory symlinked to a separate disk (often for performance reasons) this commit adds a --wal-dir flag to the keeper. The symlink to a new WAL disk needs to be created as part of the database initialisation step, and also whenever we clobber the database, such as when taking a pg_basebackup (if pg_rewind is disabled/unavailable). By passing this directory as an argument to initdb and pg_basebackup, we can cover all the scenarios that the keeper erases and recreates the data directory, ensuring the symlink is always present. * Support waldir in pitr command For those who use different devices for wal and data directory, we should support the interpolation of the wal directory location in the pitr command as we do the data directory. This allows people to supply commands like: ``` pg_basebackup --pgdata %d --waldir %w ... ``` And have both data directory and wal directory templated. pg_basebackup and initdb are commands that support the concept of waldir, but this could be useful for any arbitrary pitr command. The commit also simplifies the implementation of the expand function to feature less mutation and slice offset accesses. * Also remove wal directory when destroying data If a wal directory is supplied then it's important to clean-out our wals along with our data directory. This commit renames the existing RemoveAll method to RemoveAllIfInitialized, which better represents what it does, and has it rely on a RemoveAll method that cleans-up both data directory and wal. Co-authored-by: Harry Maclean <harrymaclean@gocardless.com>
Configuration menu - View commit details
-
Copy full SHA for 0d2d28b - Browse repository at this point
Copy the full SHA 0d2d28bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56fa48d - Browse repository at this point
Copy the full SHA 56fa48dView commit details
Commits on Feb 21, 2022
-
With this change we also move the wal to new location if --wal-dir lo…
…cation is changed
Configuration menu - View commit details
-
Copy full SHA for 10324de - Browse repository at this point
Copy the full SHA 10324deView commit details
Commits on Feb 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3351414 - Browse repository at this point
Copy the full SHA 3351414View commit details
Commits on May 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f09e493 - Browse repository at this point
Copy the full SHA f09e493View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6235160 - Browse repository at this point
Copy the full SHA 6235160View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.