Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak README.md and add instructions to setup the EO client #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrzrdx
Copy link

@chrzrdx chrzrdx commented Sep 22, 2024

  • Clean up instructions in README.md
  • Add instructions to setup EO client
  • Replace compose.yml setup with a docker command in README.md to spin up MySQL when developing locally. This also removed the need to have an .env file altogether. We might bring .env back in a later iteration if we didn't want to check in changes to the database connection settings in Config.toml.

@chrzrdx chrzrdx changed the title Housekeeping Tweak README.md and add instructions to setup the EO client Sep 22, 2024
Copy link
Owner

@sorokya sorokya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes to the README otherwise looks great! Thanks @chrzrdx 😊

README.md Outdated
@@ -2,51 +2,71 @@

# REOSERV

The rust powered [Endless Online](https://game.eoserv.net/) server emulator!
The Rust-powered server emulator for [Endless Online](https://game.eoserv.net/) 🦀
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have fixed this a while ago but can you change the URL here to https://endless-online.com

README.md Outdated
To build the server simply run
- [Rust](https://www.rust-lang.org/)
- [Cargo](https://doc.rust-lang.org/cargo/appendix/glossary.html#cargo)
- [Docker](https://docs.docker.com/engine/install/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker isn't required for building the server. Just recommended for running in dev environments

README.md Outdated

You can run the server with
- `debug`: This will print human-readable data structures for every packet.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer true, I removed the debug packet printing a while back :P

I'm pretty sure trace will print raw byte arrays though

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, should we remove the RUST_LOG flag completely (as a configuration option for the user)?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it doesn't need to be exposed no

README.md Outdated

`cargo run`
## Setup quests, NPCs and items for your server
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a link to the docs here

See [docs](https://reoserv.net/docs/pubs) for help

@chrzrdx
Copy link
Author

chrzrdx commented Sep 23, 2024

@sorokya We can also consider moving eo-client to its own repository, and link to that in the docs (or in CONTRIBUTING.md)

@chrzrdx chrzrdx force-pushed the housekeeping branch 2 times, most recently from 97ed8fd to c943997 Compare September 23, 2024 17:23
- Clean up instructions in README.md
- Add instructions to setup EO client
- Replace compose.yml setup with a docker command in README.md to spin up MySQL when developing locally. This also removes the need to have an .env file altogether. We might bring .env back in a later iteration if we didn't want to check in changes to the database connection settings in Config.toml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants