-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dark mode #700
Conversation
Can you break out bootstrap upgrade into a separate PR? That'll be something we would need to merge first and is definitely easier to check/verify independently from the other changes you're proposing. |
<link rel="stylesheet" href="static/css/bootstrap.css"></link> | ||
<link rel="stylesheet" href="static/css/font-awesome.css"></link> | ||
<link rel="stylesheet" href="static/css/app.css"></link> | ||
<link rel="stylesheet" href="static/css/bootstrap.min.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the old formatting here
@@ -35,14 +40,17 @@ | |||
</ul> | |||
|
|||
<div class="connection-actions"> | |||
<a href="#" id="edit_connection" class="btn btn-default btn-sm"><i class="fa fa-database"></i> Connect</a> | |||
<a href="#" id="close_connection" class="btn btn-default btn-sm">Disconnect</a> | |||
<a href="#" id="edit_connection" class="btn btn-default text-white btn-sm"><i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using some kind of auto formatter for html here? The tag content looks broken over the lines
var bookmarks = {}; | ||
var default_rows_limit = 100; | ||
var currentObject = null; | ||
var appInfo = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the original formatting in this file
Hi @sosedoff |
this PR is addressing the feature requested at #606
Changes
data-bs-theme
attribute