Async NonBlockingFileIO #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
force-pushed
the
async-nonblocking-fileio
branch
2 times, most recently
from
fafd664
to
0bee30b
Compare
0xTim
requested changes
Mar 30, 2024
| let threadPool = NIOThreadPool(numberOfThreads: 1) | ||
| threadPool.start() | ||
| defer { threadPool.shutdownGracefully { _ in }} | ||
| let fileIO = NonBlockingFileIO(threadPool: threadPool) | ||
|
|
||
| let fileBuffer = try await loadFile(path: tokenFile, on: eventLoop, using: fileIO).get() | ||
| let fileBuffer = try await loadFile(path: tokenFile, using: fileIO) | ||
| let token = String(buffer: fileBuffer) | ||
| return token | ||
| } | ||
|
|
||
| /// Load a file from disk without blocking the current thread | ||
| /// - Returns: Event loop future with file contents in a byte-buffer |
There was a problem hiding this comment.
This comment needs updating as it no longer returns a future
0xTim
approved these changes
Mar 31, 2024
adam-fowler
force-pushed
the
async-nonblocking-fileio
branch
from
564c2af
to
d154235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use async NonBlockingFileIO calls
Updates for AWSHTTPClient protocol