Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
  • Loading branch information
soulxu committed Nov 23, 2023
1 parent 7fa90da commit 27741bb
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions source/common/io/io_uring_worker_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -475,8 +475,6 @@ void IoUringServerSocket::onRead(Request* req, int32_t result, bool injected) {
}

// If `enable_close_event_` is true, then deliver the remote close as close event.
// TODO (soulxu): Add test for the case the status is enabled, but listen on the closed
// event. This case is used for listener filter.
if (read_error_.has_value() && read_error_ == 0) {
if (enable_close_event_) {
ENVOY_LOG(trace,
Expand All @@ -491,8 +489,6 @@ void IoUringServerSocket::onRead(Request* req, int32_t result, bool injected) {
// In this case, the closed event isn't listened and the status is disabled.
// It means we can't raise the closed or read event. So we only can raise the
// write event.
// TODO (soulxu): We should try to move this logic to the
// `IoUringSocketHandle::onRemoteClose()`.
ENVOY_LOG(trace,
"remote closed and close event disabled, raise the write event, fd = "
"{}, result = {}",
Expand Down

0 comments on commit 27741bb

Please sign in to comment.