sdk changes for SuperMinterV2 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 83512d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vigneshka
force-pushed
the
vigneshka/sdk-changes
branch
from
d95d9c8 to
a1b16ab
Compare
vigneshka
force-pushed
the
vigneshka/sdk-changes
branch
from
3216d11 to
50225c6
Compare
vigneshka
force-pushed
the
vigneshka/sdk-changes
branch
from
50225c6 to
c8fc60c
Compare
vigneshka
force-pushed
the
vigneshka/sdk-changes
branch
from
c8fc60c to
41cfee4
Compare
vigneshka
force-pushed
the
vigneshka/sdk-changes
branch
from
41cfee4 to
f623f84
Compare
PabloSzx
requested changes
Dec 14, 2023
vigneshka
force-pushed
the
vigneshka/sdk-changes
branch
from
b1edf8d to
8bb00a2
Compare
vigneshka
force-pushed
the
vigneshka/sdk-changes
branch
from
8bb00a2 to
91368eb
Compare
vigneshka
force-pushed
the
vigneshka/sdk-changes
branch
from
91368eb to
28d4d2a
Compare
vigneshka
changed the title
PabloSzx
reviewed
Dec 18, 2023
| if (this.cache.has(key)) { | ||
| return this.cache.get(key) as T | ||
| } | ||
| const data = await fetchData() |
There was a problem hiding this comment.
I still feel like making this call idempotent would be worth
PabloSzx
reviewed
Dec 18, 2023
Comment on lines
48
to
50
| const version = superMinter.version | ||
|
|
||
| switch (version) { |
There was a problem hiding this comment.
Suggested change
| const version = superMinter.version | |
| switch (version) { | |
| switch (superMinter.version) { |
PabloSzx
reviewed
Dec 18, 2023
| }) | ||
| } | ||
| default: | ||
| exhaustiveGuard(version) |
There was a problem hiding this comment.
Suggested change
| exhaustiveGuard(version) | |
| exhaustiveGuard(superMinter) |
vigneshka
commented
Dec 18, 2023
PabloSzx
approved these changes
Dec 18, 2023
PabloSzx
reviewed
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.