Skip to content

Update ag-grid monorepo to v35 (major)#3488

Open
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/major-ag-grid-monorepo
Open

Update ag-grid monorepo to v35 (major)#3488
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/major-ag-grid-monorepo

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Dec 19, 2025

This PR contains the following updates:

Package Change Age Confidence
ag-grid-community (source) ^34.1.1^35.0.0 age confidence
ag-grid-react (source) ^34.1.1^35.0.0 age confidence

Release Notes

ag-grid/ag-grid (ag-grid-community)

v35.2.1

Compare Source

v35.2.0

Compare Source

v35.1.0

Compare Source

v35.0.1

Compare Source

v35.0.0

Compare Source


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies This pull request updates dependency files label Dec 19, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 19, 2025

Coverage Report for CI Build 24257495190

Coverage remained the same at 40.886%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13769
Covered Lines: 6073
Line Coverage: 44.11%
Relevant Branches: 6991
Covered Branches: 2415
Branch Coverage: 34.54%
Branches in Coverage %: Yes
Coverage Strength: 28.97 hits per line

💛 - Coveralls

@renovate renovate bot force-pushed the renovate/major-ag-grid-monorepo branch from 24e3804 to 7660232 Compare December 21, 2025 18:48
@renovate renovate bot force-pushed the renovate/major-ag-grid-monorepo branch 4 times, most recently from 106f672 to 79d8de5 Compare December 26, 2025 05:44
@renovate renovate bot force-pushed the renovate/major-ag-grid-monorepo branch 3 times, most recently from f01b4dd to 3cd3d13 Compare December 30, 2025 00:36
@renovate renovate bot force-pushed the renovate/major-ag-grid-monorepo branch 17 times, most recently from 6c65b89 to ba3fe4e Compare January 18, 2026 04:57
@renovate renovate bot force-pushed the renovate/major-ag-grid-monorepo branch 2 times, most recently from 3c9033a to 11704b7 Compare January 21, 2026 17:27
@renovate renovate bot force-pushed the renovate/major-ag-grid-monorepo branch 6 times, most recently from bd70364 to bf61f0f Compare January 31, 2026 05:41
@renovate renovate bot force-pushed the renovate/major-ag-grid-monorepo branch 19 times, most recently from 5db98aa to ca34fbe Compare February 8, 2026 15:48
@renovate renovate bot force-pushed the renovate/major-ag-grid-monorepo branch from ca34fbe to f0dd581 Compare February 9, 2026 10:44
Comment on lines 52 to +55
"ace-builds": "^1.42.1",
"acorn": "^8.9.0",
"ag-grid-community": "^34.1.1",
"ag-grid-react": "^34.1.1",
"ag-grid-community": "^35.0.0",
"ag-grid-react": "^35.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The upgrade to ag-grid v35 introduces automatic overlays that conflict with the code's use of deprecated manual overlay APIs like hideOverlay() and showNoRowsOverlay().
Severity: MEDIUM

Suggested Fix

Update the code to use the modern ag-grid v35 API. Either remove the deprecated manual calls to hideOverlay() and showNoRowsOverlay() and rely on the new automatic overlays, or explicitly suppress the new behavior using the suppressOverlays grid option (e.g., suppressOverlays=['noMatchingRows']) if manual control is still desired.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L52-L55

Potential issue: The upgrade to `ag-grid` v35 introduces a new automatic overlay system
for tables. However, components like `GradingSubmissionsTable.tsx` and
`OverallLeaderboard.tsx` continue to use deprecated manual overlay control APIs
(`hideOverlay()`, `showNoRowsOverlay()`), which were deprecated in v32. This conflict
between the new automatic behavior and the old manual calls can lead to duplicate or
flickering overlays. For example, when a floating filter in `GradingSubmissionsTable`
yields no results, both the new automatic overlay and the manually triggered one might
appear, creating a confusing user experience.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude code says: This sentry bot comment is partially valid but not critical. Here's the analysis:

What's actually happening:

  • GradingSubmissionsTable.tsx:308 calls gridRef.current!.api.hideOverlay()
  • GradingSubmissionsTable.tsx:311 calls gridRef.current!.api.showNoRowsOverlay()
  • It also uses overlayLoadingTemplate and overlayNoRowsTemplate props (lines 136-138)

However, these APIs are deprecated but not removed in v35 — if they were removed, TypeScript compilation would have failed, and CI passed cleanly. So this is a deprecation warning
situation, not a breakage.

The real risk is the behavioral one the bot describes: ag-grid v35's new automatic overlay system could conflict with these manual calls, potentially causing duplicate/flickering
overlays in the grading table. This wouldn't be caught by tests since it's a visual/UX issue.

Verdict: The PR is still safe to merge — it won't break the build or crash anything. But there's a minor UX risk of overlay quirks in the grading submissions table.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should check if we can migrate to ag-grid v35. Some more investigation needed.

Comment on lines 52 to +55
"ace-builds": "^1.42.1",
"acorn": "^8.9.0",
"ag-grid-community": "^34.1.1",
"ag-grid-react": "^34.1.1",
"ag-grid-community": "^35.0.0",
"ag-grid-react": "^35.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The code calls api.hideOverlay() and api.showNoRowsOverlay(), which are likely removed in ag-grid v35, causing a runtime TypeError in the grading submissions table.
Severity: HIGH

Suggested Fix

Remove the imperative calls to api.hideOverlay() and api.showNoRowsOverlay() from the useEffect hook. Rely on the declarative loading prop, which is already passed to AgGridReact, to control the loading overlay. The 'no rows' overlay is handled automatically by the grid when data is empty, so the explicit call is unnecessary.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L52-L55

Potential issue: The upgrade to `ag-grid` v35 is likely to cause a runtime error in
`GradingSubmissionsTable.tsx`. The `useEffect` hook in this component calls
`api.hideOverlay()` and `api.showNoRowsOverlay()`. These imperative API methods for
managing overlays are likely deprecated or removed in v35, which favors a declarative
approach using the `loading` prop. If these methods no longer exist on the grid API, the
application will throw a `TypeError` whenever the component's `useEffect` hook is
triggered by changes to submissions or request counters, breaking the grading
submissions table functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies This pull request updates dependency files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants