Conversation
Coverage Report for CI Build 24257495190Coverage remained the same at 40.886%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
24e3804 to
7660232
Compare
106f672 to
79d8de5
Compare
f01b4dd to
3cd3d13
Compare
6c65b89 to
ba3fe4e
Compare
3c9033a to
11704b7
Compare
bd70364 to
bf61f0f
Compare
5db98aa to
ca34fbe
Compare
ca34fbe to
f0dd581
Compare
| "ace-builds": "^1.42.1", | ||
| "acorn": "^8.9.0", | ||
| "ag-grid-community": "^34.1.1", | ||
| "ag-grid-react": "^34.1.1", | ||
| "ag-grid-community": "^35.0.0", | ||
| "ag-grid-react": "^35.0.0", |
There was a problem hiding this comment.
Bug: The upgrade to ag-grid v35 introduces automatic overlays that conflict with the code's use of deprecated manual overlay APIs like hideOverlay() and showNoRowsOverlay().
Severity: MEDIUM
Suggested Fix
Update the code to use the modern ag-grid v35 API. Either remove the deprecated manual calls to hideOverlay() and showNoRowsOverlay() and rely on the new automatic overlays, or explicitly suppress the new behavior using the suppressOverlays grid option (e.g., suppressOverlays=['noMatchingRows']) if manual control is still desired.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L52-L55
Potential issue: The upgrade to `ag-grid` v35 introduces a new automatic overlay system
for tables. However, components like `GradingSubmissionsTable.tsx` and
`OverallLeaderboard.tsx` continue to use deprecated manual overlay control APIs
(`hideOverlay()`, `showNoRowsOverlay()`), which were deprecated in v32. This conflict
between the new automatic behavior and the old manual calls can lead to duplicate or
flickering overlays. For example, when a floating filter in `GradingSubmissionsTable`
yields no results, both the new automatic overlay and the manually triggered one might
appear, creating a confusing user experience.
There was a problem hiding this comment.
Claude code says: This sentry bot comment is partially valid but not critical. Here's the analysis:
What's actually happening:
- GradingSubmissionsTable.tsx:308 calls gridRef.current!.api.hideOverlay()
- GradingSubmissionsTable.tsx:311 calls gridRef.current!.api.showNoRowsOverlay()
- It also uses overlayLoadingTemplate and overlayNoRowsTemplate props (lines 136-138)
However, these APIs are deprecated but not removed in v35 — if they were removed, TypeScript compilation would have failed, and CI passed cleanly. So this is a deprecation warning
situation, not a breakage.
The real risk is the behavioral one the bot describes: ag-grid v35's new automatic overlay system could conflict with these manual calls, potentially causing duplicate/flickering
overlays in the grading table. This wouldn't be caught by tests since it's a visual/UX issue.
Verdict: The PR is still safe to merge — it won't break the build or crash anything. But there's a minor UX risk of overlay quirks in the grading submissions table.
There was a problem hiding this comment.
I guess we should check if we can migrate to ag-grid v35. Some more investigation needed.
| "ace-builds": "^1.42.1", | ||
| "acorn": "^8.9.0", | ||
| "ag-grid-community": "^34.1.1", | ||
| "ag-grid-react": "^34.1.1", | ||
| "ag-grid-community": "^35.0.0", | ||
| "ag-grid-react": "^35.0.0", |
There was a problem hiding this comment.
Bug: The code calls api.hideOverlay() and api.showNoRowsOverlay(), which are likely removed in ag-grid v35, causing a runtime TypeError in the grading submissions table.
Severity: HIGH
Suggested Fix
Remove the imperative calls to api.hideOverlay() and api.showNoRowsOverlay() from the useEffect hook. Rely on the declarative loading prop, which is already passed to AgGridReact, to control the loading overlay. The 'no rows' overlay is handled automatically by the grid when data is empty, so the explicit call is unnecessary.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L52-L55
Potential issue: The upgrade to `ag-grid` v35 is likely to cause a runtime error in
`GradingSubmissionsTable.tsx`. The `useEffect` hook in this component calls
`api.hideOverlay()` and `api.showNoRowsOverlay()`. These imperative API methods for
managing overlays are likely deprecated or removed in v35, which favors a declarative
approach using the `loading` prop. If these methods no longer exist on the grid API, the
application will throw a `TypeError` whenever the component's `useEffect` hook is
triggered by changes to submissions or request counters, breaking the grading
submissions table functionality.
This PR contains the following updates:
^34.1.1→^35.0.0^34.1.1→^35.0.0Release Notes
ag-grid/ag-grid (ag-grid-community)
v35.2.1Compare Source
v35.2.0Compare Source
v35.1.0Compare Source
v35.0.1Compare Source
v35.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.