Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update Repository to Node 20" #272

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

RichDom2185
Copy link
Member

Reverts #271 due to the following error:

image

@RichDom2185 RichDom2185 requested a review from leeyi45 January 26, 2024 19:21
@RichDom2185 RichDom2185 self-assigned this Jan 26, 2024
@leeyi45
Copy link
Contributor

leeyi45 commented Jan 26, 2024

Oops I think I forgot that this was reliant on the PR I have open with js-slang. If that's going to take some more time I can reopen this one without that change

@RichDom2185
Copy link
Member Author

Oh do you mean the full-async branch? I don't see a PR open yet.

I think we have some time for now, but if people start needing to work on some modules, then we need to merge this (revert) PR so that they can test locally.

@leeyi45
Copy link
Contributor

leeyi45 commented Jan 26, 2024

The import-checker branch, actually

@Cloud7050 Cloud7050 self-requested a review January 27, 2024 01:01
@RichDom2185 RichDom2185 merged commit 32242aa into master Jan 27, 2024
3 checks passed
@RichDom2185 RichDom2185 deleted the revert-271-node20 branch January 27, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants