refactor(authentication-service): update urls and add scope for keycloak idp #2176
Conversation
Tyagi-Sunny
force-pushed
the
gh-keycloak
branch
from
43d27ce
to
5c40cba
Compare
|
@Tyagi-Sunny update the readme file saying that people using the older version can still use this by only updating the KEYCLOCK_HOST and appending '/auth/realms' to its existing value |
…oak idp update urls and add scope for keycloak idp BREAKING CHANGE: yes 47
add realm to kecloak host env BREAKING CHANGE: yes 0
update readme for keycloak url changes gh-0
Tyagi-Sunny
force-pushed
the
gh-keycloak
branch
from
c521dd4
to
385eace
Compare
added |
|
| <td>Hostname of the Keycloak instance. For all keycloak version below 17, user can still use this by only updating the KEYCLOCK_HOST and appending '/auth/realms' to its existing value</td> | ||
| <td></td> | ||
| </tr> | ||
| <tr> |
There was a problem hiding this comment.
what about the extra scope parameter that we are passing
will that cause any issue for older versions of keyclock
There was a problem hiding this comment.
Adding a default scope: 'openid' is good practice, as some configurations expect this scope to be explicitly specified for OpenID Connect flows.The scope parameter should work across Keycloak versions without issue.
update urls and add scope for keycloak idp
BREAKING CHANGE:
yes
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: