Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opensearch module refactor #29

Merged
merged 8 commits into from
Nov 14, 2024
Merged

Conversation

Arunsai14
Copy link

@Arunsai14 Arunsai14 commented Nov 5, 2024

Description

Terraform module to deploy and configure an Amazon OpenSearch Service domain with customizable settings from scratch

Related Issue

Checklist

Please ensure that the following steps are completed before submitting the pull request:

  • Code follows the Terraform best practices and style guidelines.
  • Changes are appropriately documented, including any necessary updates to README or other documentation files.
  • Unit tests have been added or updated to cover the changes introduced by this pull request.
  • Changes have been tested locally and verified to work as expected.
  • The code has been reviewed to ensure it aligns with the project's goals and standards.
  • Dependencies and backward compatibility have been considered and addressed if applicable.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Testing Instructions

Ran terraform apply in Example Folder
image

Screenshots

image

Additional Notes

Add any additional notes or context that might be helpful for reviewers or users testing the changes.

@Arunsai14 Arunsai14 force-pushed the feature/refactor-opensearch branch 10 times, most recently from 026d909 to c91f3d3 Compare November 6, 2024 05:09
@vijay-stephen
Copy link
Collaborator

@Arunsai14 rename non-vpc to public

variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@vijay-stephen
Copy link
Collaborator

@Arunsai14 Add serverless option as well

@vijay-stephen vijay-stephen marked this pull request as ready for review November 6, 2024 06:05
@Arunsai14 Arunsai14 force-pushed the feature/refactor-opensearch branch 8 times, most recently from beb39cd to 07b0c4d Compare November 7, 2024 09:11
@Arunsai14 Arunsai14 force-pushed the feature/refactor-opensearch branch 15 times, most recently from e36890f to 56e8603 Compare November 14, 2024 09:36
Copy link

sonarcloud bot commented Nov 14, 2024

outputs.tf Outdated Show resolved Hide resolved
@vijay-stephen vijay-stephen merged commit 53218f7 into main Nov 14, 2024
5 checks passed
@vijay-stephen vijay-stephen deleted the feature/refactor-opensearch branch November 14, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants