fix: handling of last line without newline in hunks #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Some editors (depending on editor configuration) change the last line of a file by adding a missing newline. But in order to keep diffs at a minimum, it's sometimes advisable to not include this change into the commit. This should be possible by discarding the hunk with this change. Now it is possible to discard (or stage/unstage) such a change. Previously discarding such a change was ignored, when there were other changes in the same file.
love-linger
added a commit
that referenced
this pull request
Nov 10, 2025
For untracked/added file, `\\ No newline at end of file` will always be added to the end of patch. Signed-off-by: leo <longshuang@msn.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Some editors (depending on editor configuration) change the last line of a file by adding a missing newline. But in order to keep diffs at a minimum, it's sometimes advisable to not include this change into the commit. This should be possible by discarding the hunk with this change.
Now it is possible to discard (or stage/unstage) such a change. Previously discarding such a change was ignored, when there were other changes in the same file.