This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
build(bazel): upgrade to rules_js 2.0 RC #63022
Merged
+27
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
aspect/rules_js_2
branch
2 times, most recently
from
a8178e7
to
f55c7b4
Compare
Strum355
force-pushed
the
aspect/rules_js_2
branch
from
e43a2ae
to
59be5e4
Compare
Strum355
referenced
this pull request
Jun 6, 2024
…63143) This regressed in https://github.com/sourcegraph/sourcegraph/pull/63022 where the custom `gather_files_from_js_providers` function that was copied over from rules_js 1.x was including runfiles. Resolves eslint failures seen in https://buildkite.com/sourcegraph/sourcegraph/builds/277072#018fe743-abac-44d8-911b-d5a7ed425413 and observed locally: ``` (07:19:15) INFO: From ESLint client/wildcard/wildcard_lib_eslint-output.txt: | | Oops! Something went wrong! :( | | ESLint: 8.57.0 | | ESLint couldn't find a configuration file. To set up a configuration file for this project, please run: | | npm init @eslint/config | | ESLint looked for configuration files in /tmp/bazel-working-directory/__main__/bazel-out/k8-fastbuild/bin/client/wildcard/src/components/Alert and its ancestors. If it found none, it then looked in your home directory. | | If you think you already have a configuration file or if you need more help, please stop by the ESLint Discord server: https://eslint.org/chat ``` ## Test plan CI (check test logs) ## Changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps to rules_js (and friends) to 2.0 RCs.
This brings in performance improvements for analysis phase since npm package depsets and now much smaller. It also adds support for pnpm v9 and allows for linking js_library targets as 1p deps instead of npm_package targets. See aspect-build/rules_js#1671 for more details.
Test plan
CI
Changelog