This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
build(bazel): fixup custom eslint test rule after bump to rules_js 2 #63143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed in https://github.com/sourcegraph/sourcegraph/pull/63022 where the custom
gather_files_from_js_providers
function that was copied over from rules_js 1.x was including runfiles (which would have also included all sources & transitive source implicitly as well).Resolves eslint failures seen in https://buildkite.com/sourcegraph/sourcegraph/builds/277072#018fe743-abac-44d8-911b-d5a7ed425413 and observed locally:
Test plan
CI (check test logs)
Changelog