This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Add some logging for modelconfig problems #64310
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time trying to troubleshoot why I wasn't getting the expected results from modelconfig. And it turns out, that there are some codepaths where
conf.GetCompletionsConfig(siteConfig)
returnsnil
but without any other sort of notification.e.g. if you are using
azure-openai
and do not specify theendpoint
field,computed.go
will just bail rather than supply a default.This should probably just be a site configuration error, since otherwise Cody Enterprise won't work correctly. (Now with the modelconfig, we will act as if no site configuration was supplied at all and default to just using the statically embedded models, which is fairly surprising.)
Anyways, this PR just adds some logging to make this easier to track down if it happens again. I don't know how much time we would want to spend preventing errors for the "completions" config since.
Test plan
NA
Changelog
NA