Support old Clang versions #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: 5e2da5c | Previous: 514001a | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.2262390393422637 ns/iter |
2.20721554421779 ns/iter |
1.01 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.1931607473613632 ns/iter |
2.206285388328121 ns/iter |
0.99 |
Regex_Period_Asterisk |
2.2039891800824587 ns/iter |
2.201432701242794 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.1975658196557406 ns/iter |
2.2133372681626606 ns/iter |
0.99 |
Regex_Period_Plus |
2.7974735924199297 ns/iter |
2.799835018503954 ns/iter |
1.00 |
Regex_Period |
2.70697798284056 ns/iter |
2.7963626117232607 ns/iter |
0.97 |
Regex_Caret_Period_Plus_Dollar |
2.4878522007501553 ns/iter |
2.7991588517812476 ns/iter |
0.89 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.4875028173211127 ns/iter |
2.797277495344344 ns/iter |
0.89 |
Regex_Caret_Period_Asterisk_Dollar |
2.48758659110327 ns/iter |
3.416646187753847 ns/iter |
0.73 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.225720620635112 ns/iter |
3.417477563680063 ns/iter |
0.65 |
Regex_Caret_X_Hyphen |
13.083612266276916 ns/iter |
12.591959179417852 ns/iter |
1.04 |
Regex_Period_Md_Dollar |
81.69235067543276 ns/iter |
81.70918920930372 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
5.596812038329612 ns/iter |
6.844252091524863 ns/iter |
0.82 |
Regex_Caret_Period_Range_Dollar |
2.8003385406855092 ns/iter |
4.040532126139264 ns/iter |
0.69 |
Regex_Nested_Backtrack |
504.90397699991263 ns/iter |
500.0191541346797 ns/iter |
1.01 |
JSON_Array_Of_Objects_Unique |
410.217242530318 ns/iter |
404.9806391909687 ns/iter |
1.01 |
JSON_Parse_1 |
30731.36137616884 ns/iter |
30501.04911659018 ns/iter |
1.01 |
JSON_Fast_Hash_Helm_Chart_Lock |
58.485983076119375 ns/iter |
58.46988820081462 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
165.02092450624468 ns/iter |
145.62188792390634 ns/iter |
1.13 |
JSON_String_Equal/10 |
7.782390896405156 ns/iter |
7.148112807661105 ns/iter |
1.09 |
JSON_String_Equal/100 |
8.401169743199606 ns/iter |
6.84496456405244 ns/iter |
1.23 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9345466447743438 ns/iter |
0.9347368203045362 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
10.263648037600142 ns/iter |
14.60084600454091 ns/iter |
0.70 |
JSON_String_Fast_Hash/10 |
2.4863232329434704 ns/iter |
2.4863247847793777 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
2.488358126128055 ns/iter |
2.485352276415761 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
2.1790995877979595 ns/iter |
2.6903715841438993 ns/iter |
0.81 |
JSON_String_Key_Hash/100 |
1.867591185723609 ns/iter |
1.866550116741216 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.73973037271891 ns/iter |
3.7330476930570877 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.739180726950415 ns/iter |
3.7372609388212257 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.733821605611434 ns/iter |
3.7344417368782805 ns/iter |
1.00 |
Pointer_Object_Traverse |
44.2406169541814 ns/iter |
45.04234454921942 ns/iter |
0.98 |
Pointer_Object_Try_Traverse |
52.298757153967095 ns/iter |
52.38964761935102 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
288.0513656792093 ns/iter |
306.67659864935155 ns/iter |
0.94 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/llvm)
| Benchmark suite | Current: 5e2da5c | Previous: 514001a | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
1.7132523565618827 ns/iter |
2.039168550879791 ns/iter |
0.84 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.74977910672695 ns/iter |
2.1743155860024928 ns/iter |
0.80 |
Regex_Period_Asterisk |
1.7678072529400406 ns/iter |
2.3866593481865297 ns/iter |
0.74 |
Regex_Group_Period_Asterisk_Group |
1.6678660657468305 ns/iter |
2.2003207489224583 ns/iter |
0.76 |
Regex_Period_Plus |
2.0520908874184864 ns/iter |
2.561857576637343 ns/iter |
0.80 |
Regex_Period |
2.2164540640048265 ns/iter |
2.6117893271182577 ns/iter |
0.85 |
Regex_Caret_Period_Plus_Dollar |
2.1551139002772945 ns/iter |
2.400864292401077 ns/iter |
0.90 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.303318459526319 ns/iter |
2.6556070161135974 ns/iter |
0.87 |
Regex_Caret_Period_Asterisk_Dollar |
1.7475026687938273 ns/iter |
2.2964480278595003 ns/iter |
0.76 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.8681387206719033 ns/iter |
2.4589279896007517 ns/iter |
0.76 |
Regex_Caret_X_Hyphen |
7.97429095949949 ns/iter |
8.392715719557458 ns/iter |
0.95 |
Regex_Period_Md_Dollar |
81.50693998381008 ns/iter |
86.88462279475065 ns/iter |
0.94 |
Regex_Caret_Slash_Period_Asterisk |
6.236573487752047 ns/iter |
6.2307088308850345 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
2.8183292331518643 ns/iter |
2.7404288084699293 ns/iter |
1.03 |
Regex_Nested_Backtrack |
878.4355317929089 ns/iter |
877.1012886481179 ns/iter |
1.00 |
JSON_Array_Of_Objects_Unique |
369.6872659379832 ns/iter |
408.33642546982975 ns/iter |
0.91 |
JSON_Parse_1 |
25218.423079677927 ns/iter |
31875.981996725088 ns/iter |
0.79 |
JSON_Fast_Hash_Helm_Chart_Lock |
58.37250565048413 ns/iter |
75.7656807559545 ns/iter |
0.77 |
JSON_Equality_Helm_Chart_Lock |
148.12766220307054 ns/iter |
144.90512033333874 ns/iter |
1.02 |
JSON_String_Equal/10 |
9.678220085060488 ns/iter |
8.902251415093126 ns/iter |
1.09 |
JSON_String_Equal/100 |
7.274898896776777 ns/iter |
7.6525372048429405 ns/iter |
0.95 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.35948749180131906 ns/iter |
0.3509789707190708 ns/iter |
1.02 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
3.5729363454981313 ns/iter |
3.3449214512347667 ns/iter |
1.07 |
JSON_String_Fast_Hash/10 |
1.8665193249353205 ns/iter |
1.7499961507276407 ns/iter |
1.07 |
JSON_String_Fast_Hash/100 |
2.140393143887807 ns/iter |
2.106028344609897 ns/iter |
1.02 |
JSON_String_Key_Hash/10 |
1.475950043572973 ns/iter |
1.4007969342317637 ns/iter |
1.05 |
JSON_String_Key_Hash/100 |
1.5251194117473115 ns/iter |
1.390808707188053 ns/iter |
1.10 |
JSON_Object_Defines_Miss_Same_Length |
2.473629317138317 ns/iter |
2.466603360561875 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
2.636350080563352 ns/iter |
2.4130128544860567 ns/iter |
1.09 |
JSON_Object_Defines_Miss_Too_Large |
2.4544623582172798 ns/iter |
2.4148075993888063 ns/iter |
1.02 |
Pointer_Object_Traverse |
17.128228589796812 ns/iter |
17.136081343343275 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
24.560064568475987 ns/iter |
24.589601881948305 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
188.01916536754052 ns/iter |
194.64998084353888 ns/iter |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
| Benchmark suite | Current: 5e2da5c | Previous: 514001a | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
7.115012276785697 ns/iter |
7.16802343750013 ns/iter |
0.99 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
7.0145334821423795 ns/iter |
6.853013392857932 ns/iter |
1.02 |
Regex_Period_Asterisk |
7.489338169643288 ns/iter |
7.104960937500999 ns/iter |
1.05 |
Regex_Group_Period_Asterisk_Group |
6.914604910714621 ns/iter |
7.076120535714888 ns/iter |
0.98 |
Regex_Period_Plus |
7.201438616070936 ns/iter |
7.181934151785998 ns/iter |
1.00 |
Regex_Period |
7.193984374998916 ns/iter |
7.45938746669926 ns/iter |
0.96 |
Regex_Caret_Period_Plus_Dollar |
7.4966774553570605 ns/iter |
7.159333705357389 ns/iter |
1.05 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
7.25507924107178 ns/iter |
7.246714253362148 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
6.92146651785741 ns/iter |
6.9899832589280315 ns/iter |
0.99 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
7.024940848213542 ns/iter |
7.2105655928096075 ns/iter |
0.97 |
Regex_Caret_X_Hyphen |
11.790212500001118 ns/iter |
11.806790624998342 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
148.49707589285848 ns/iter |
147.2870023532574 ns/iter |
1.01 |
Regex_Caret_Slash_Period_Asterisk |
10.722276785713802 ns/iter |
10.342881250000602 ns/iter |
1.04 |
Regex_Caret_Period_Range_Dollar |
7.678611607142877 ns/iter |
7.6865879121125635 ns/iter |
1.00 |
Regex_Nested_Backtrack |
628.9288392857933 ns/iter |
617.2209821428964 ns/iter |
1.02 |
JSON_Array_Of_Objects_Unique |
449.8981116344713 ns/iter |
448.73014989374457 ns/iter |
1.00 |
JSON_Parse_1 |
80894.00669643508 ns/iter |
82239.72098214207 ns/iter |
0.98 |
JSON_Fast_Hash_Helm_Chart_Lock |
64.05964285714764 ns/iter |
64.32880357142575 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
200.8802566571081 ns/iter |
194.37308953692892 ns/iter |
1.03 |
JSON_String_Equal/10 |
9.626022278455494 ns/iter |
9.685406206761101 ns/iter |
0.99 |
JSON_String_Equal/100 |
9.929473616386085 ns/iter |
10.078443705007787 ns/iter |
0.99 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
2.166171874999989 ns/iter |
2.1735803124997233 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.90308705357078 ns/iter |
14.726904017857226 ns/iter |
1.01 |
JSON_String_Fast_Hash/10 |
3.714228207653098 ns/iter |
3.8073186383926125 ns/iter |
0.98 |
JSON_String_Fast_Hash/100 |
3.722244100496457 ns/iter |
3.998909992859056 ns/iter |
0.93 |
JSON_String_Key_Hash/10 |
7.614158482141927 ns/iter |
7.439792857142485 ns/iter |
1.02 |
JSON_String_Key_Hash/100 |
4.023615498255464 ns/iter |
4.027064560762218 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.723439704002677 ns/iter |
3.72483963620534 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.7225464004337323 ns/iter |
3.717931064789373 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
4.952957000000424 ns/iter |
4.972566071429137 ns/iter |
1.00 |
Pointer_Object_Traverse |
54.35851785715532 ns/iter |
54.0291199999956 ns/iter |
1.01 |
Pointer_Object_Try_Traverse |
68.13959821427216 ns/iter |
68.19486607143281 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
183.29763243724352 ns/iter |
182.50040915180753 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: 5e2da5c | Previous: 514001a | Ratio |
|---|---|---|---|
Pointer_Object_Traverse |
50.013168658046865 ns/iter |
50.03110119999974 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
26.456623331127567 ns/iter |
26.58273383154434 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
150.49239114884824 ns/iter |
145.38519474774722 ns/iter |
1.04 |
JSON_Array_Of_Objects_Unique |
407.18637145739183 ns/iter |
419.44591400226926 ns/iter |
0.97 |
JSON_Parse_1 |
33714.83538758101 ns/iter |
33573.51954287989 ns/iter |
1.00 |
JSON_Fast_Hash_Helm_Chart_Lock |
68.47596635010608 ns/iter |
67.76144208726863 ns/iter |
1.01 |
JSON_Equality_Helm_Chart_Lock |
141.874063178438 ns/iter |
141.4998443385508 ns/iter |
1.00 |
JSON_String_Equal/10 |
5.986632747199539 ns/iter |
5.996309567234463 ns/iter |
1.00 |
JSON_String_Equal/100 |
6.613651671326375 ns/iter |
6.619637489144734 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.6232829059078713 ns/iter |
0.6253450731896726 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.290888431497176 ns/iter |
14.287609630282242 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
0.9320239096512734 ns/iter |
0.9335810179591976 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
0.9325345853693632 ns/iter |
0.9447758818682191 ns/iter |
0.99 |
JSON_String_Key_Hash/10 |
1.7112923206554833 ns/iter |
1.7144052898539979 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
2.0748711798479405 ns/iter |
2.022289023313868 ns/iter |
1.03 |
JSON_Object_Defines_Miss_Same_Length |
3.109098681228814 ns/iter |
3.118309951236335 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
2.7983231595747493 ns/iter |
2.800464380625936 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
2.4893241421149295 ns/iter |
2.48754715146793 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.808252516110541 ns/iter |
2.8010924825006738 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.812147440657409 ns/iter |
2.7961573275609193 ns/iter |
1.01 |
Regex_Period_Asterisk |
2.799849182066304 ns/iter |
2.8001857838782303 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.797789193539877 ns/iter |
2.8114902252964193 ns/iter |
1.00 |
Regex_Period_Plus |
3.418258257536844 ns/iter |
3.418893723568376 ns/iter |
1.00 |
Regex_Period |
3.4190432665351396 ns/iter |
3.418530807646378 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
3.4197178520375098 ns/iter |
3.4214362809481313 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.4219457712427523 ns/iter |
3.4224850805815525 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
4.038410547781516 ns/iter |
4.039318147642145 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
4.042420636528334 ns/iter |
4.0498905771768845 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
12.431232683350599 ns/iter |
13.050701570877218 ns/iter |
0.95 |
Regex_Period_Md_Dollar |
93.41700407479388 ns/iter |
95.62782995187261 ns/iter |
0.98 |
Regex_Caret_Slash_Period_Asterisk |
7.460742179994967 ns/iter |
7.4627480821582175 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.3497426535096695 ns/iter |
3.7027242815238797 ns/iter |
1.17 |
Regex_Nested_Backtrack |
827.421667852573 ns/iter |
827.6865807140101 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/gcc)
| Benchmark suite | Current: 5e2da5c | Previous: 514001a | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.258073711846308 ns/iter |
2.3693760568177797 ns/iter |
0.95 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.137511007717255 ns/iter |
2.2448386582671906 ns/iter |
0.95 |
Regex_Period_Asterisk |
2.037711521192631 ns/iter |
2.123902391095557 ns/iter |
0.96 |
Regex_Group_Period_Asterisk_Group |
2.1308310265896355 ns/iter |
2.1872127726200303 ns/iter |
0.97 |
Regex_Period_Plus |
1.9290496312199379 ns/iter |
1.7213223992555386 ns/iter |
1.12 |
Regex_Period |
2.0749767666088794 ns/iter |
1.7138428317499859 ns/iter |
1.21 |
Regex_Caret_Period_Plus_Dollar |
2.066875742690922 ns/iter |
1.855178463070471 ns/iter |
1.11 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.7713287416045818 ns/iter |
1.9278339658814752 ns/iter |
0.92 |
Regex_Caret_Period_Asterisk_Dollar |
2.1302094487733134 ns/iter |
2.2867923243517594 ns/iter |
0.93 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.0817564865916562 ns/iter |
2.1365788952003926 ns/iter |
0.97 |
Regex_Caret_X_Hyphen |
6.666330891113496 ns/iter |
6.84225116760729 ns/iter |
0.97 |
Regex_Period_Md_Dollar |
78.18703722513749 ns/iter |
82.37052585317998 ns/iter |
0.95 |
Regex_Caret_Slash_Period_Asterisk |
4.780080658744171 ns/iter |
4.81132966830924 ns/iter |
0.99 |
Regex_Caret_Period_Range_Dollar |
2.0913043074411393 ns/iter |
2.127269758391674 ns/iter |
0.98 |
Regex_Nested_Backtrack |
910.8900469583455 ns/iter |
907.9269042650328 ns/iter |
1.00 |
JSON_Array_Of_Objects_Unique |
240.39014260383823 ns/iter |
228.85143879599372 ns/iter |
1.05 |
JSON_Parse_1 |
25713.71778112392 ns/iter |
26037.432647533715 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
26.483071494713613 ns/iter |
28.122970368354586 ns/iter |
0.94 |
JSON_Equality_Helm_Chart_Lock |
124.31223783048377 ns/iter |
140.60225402023374 ns/iter |
0.88 |
JSON_String_Equal/10 |
5.866996538728882 ns/iter |
6.545865218294473 ns/iter |
0.90 |
JSON_String_Equal/100 |
5.492918350251849 ns/iter |
6.47271573593858 ns/iter |
0.85 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
1.031941493301348 ns/iter |
1.1136520112108483 ns/iter |
0.93 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
3.6965521307967406 ns/iter |
4.111133813363609 ns/iter |
0.90 |
JSON_String_Fast_Hash/10 |
2.077631089919533 ns/iter |
2.2405216723482977 ns/iter |
0.93 |
JSON_String_Fast_Hash/100 |
2.0390917275104754 ns/iter |
2.489500392026669 ns/iter |
0.82 |
JSON_String_Key_Hash/10 |
1.5592776662561223 ns/iter |
1.5922804512911923 ns/iter |
0.98 |
JSON_String_Key_Hash/100 |
2.05530907260852 ns/iter |
2.1631746253194724 ns/iter |
0.95 |
JSON_Object_Defines_Miss_Same_Length |
1.8710353605563876 ns/iter |
1.9875953505595807 ns/iter |
0.94 |
JSON_Object_Defines_Miss_Too_Small |
1.9950244999121822 ns/iter |
2.134561525546161 ns/iter |
0.93 |
JSON_Object_Defines_Miss_Too_Large |
1.8333215352764163 ns/iter |
1.858349234344484 ns/iter |
0.99 |
Pointer_Object_Traverse |
55.83354112289187 ns/iter |
67.31134618268709 ns/iter |
0.83 |
Pointer_Object_Try_Traverse |
38.35368340669803 ns/iter |
51.14937660567235 ns/iter |
0.75 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
168.4173178542343 ns/iter |
217.29906371021696 ns/iter |
0.78 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com