Enable cppcoreguidelines-rvalue-reference-param-not-moved #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
jviotti
reviewed
Jul 28, 2025
| // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved) | ||
| auto JSON::assign(const JSON::String &key, JSON &&value) -> void { | ||
| assert(this->is_object()); | ||
| this->data_object.emplace(key, value); |
Member
There was a problem hiding this comment.
Suggested change
| this->data_object.emplace(key, value); | |
| this->data_object.emplace(key, std::move(value)); |
Maybe what it wants is this?
Contributor
Author
There was a problem hiding this comment.
Yes, but that would conflict with another rule saying that move is ineffective
error: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg,-warnings-as-errors]
805 | this->data_object.emplace(key, std::move(value));
| ^~~~~~~~~~ ~
jviotti
reviewed
Jul 28, 2025
| std::move(other.data.begin(), other.data.end(), | ||
| std::move(other.data.begin(), std::move(other).data.end(), | ||
| std::back_inserter(this->data)); | ||
| return; |
Member
There was a problem hiding this comment.
I don't think this return is needed
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Contributor
Author
|
@jviotti PTAL |
jviotti
approved these changes
Jul 28, 2025
Member
|
Looks good, but there are conflicts again |
Member
|
Hey @bavulapati , I'm not sure that are you still working on these, so let me close them to reduce noise. Always feel free to re-open if you ever get back to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.