Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract SchemaWalkerStrategy as KeywordType #1414

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 2, 2025

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: c56aa68 Previous: e3d4f14 Ratio
JSON_Array_Of_Objects_Unique 328.4017231168189 ns/iter 330.4494081448484 ns/iter 0.99
JSON_Parse_1 21464.057459372194 ns/iter 21701.9645974385 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 50.33991940607477 ns/iter 47.91071306058982 ns/iter 1.05
JSON_Equality_Helm_Chart_Lock 140.2519209184416 ns/iter 137.82648579957984 ns/iter 1.02
Regex_Lower_S_Or_Upper_S_Asterisk 1.576017209934247 ns/iter 1.5677847860591951 ns/iter 1.01
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.585557505871529 ns/iter 1.5731284133782364 ns/iter 1.01
Regex_Period_Asterisk 1.583333862182843 ns/iter 1.565905254693926 ns/iter 1.01
Regex_Group_Period_Asterisk_Group 1.582002709968353 ns/iter 1.5674464592186697 ns/iter 1.01
Regex_Period_Plus 1.9071802450127333 ns/iter 1.8810559159476816 ns/iter 1.01
Regex_Period 1.975930548778769 ns/iter 1.881875528745847 ns/iter 1.05
Regex_Caret_Period_Plus_Dollar 1.9164646360909932 ns/iter 1.8833519950988238 ns/iter 1.02
Regex_Caret_Group_Period_Plus_Group_Dollar 1.902221299308351 ns/iter 1.8973286351646121 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 1.5816268090664736 ns/iter 1.5818838456824291 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.6016493741666316 ns/iter 1.5641900362520544 ns/iter 1.02
Regex_Caret_X_Hyphen 6.46620157148334 ns/iter 6.297649634070122 ns/iter 1.03
Regex_Period_Md_Dollar 67.45460844326 ns/iter 67.48247672645114 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 5.098934164106116 ns/iter 5.965427127926755 ns/iter 0.85
Regex_Caret_Period_Range_Dollar 2.054873352711291 ns/iter 2.03782609407208 ns/iter 1.01
Regex_Nested_Backtrack 723.8047867607063 ns/iter 732.6036863947397 ns/iter 0.99
Pointer_Object_Traverse 14.75819301588505 ns/iter 14.76069013929599 ns/iter 1.00
Pointer_Object_Try_Traverse 31.766202430873694 ns/iter 31.307038352336704 ns/iter 1.01
Pointer_Push_Back_Pointer_To_Weak_Pointer 178.3022267935555 ns/iter 172.50862811650057 ns/iter 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: c56aa68 Previous: e3d4f14 Ratio
JSON_Array_Of_Objects_Unique 441.229399113195 ns/iter 437.71626443914045 ns/iter 1.01
JSON_Parse_1 30231.563428570043 ns/iter 32074.64251607191 ns/iter 0.94
JSON_Fast_Hash_Helm_Chart_Lock 54.76047488803838 ns/iter 62.227064830337405 ns/iter 0.88
JSON_Equality_Helm_Chart_Lock 149.55555221235346 ns/iter 151.71289603815802 ns/iter 0.99
Regex_Lower_S_Or_Upper_S_Asterisk 2.183036276893729 ns/iter 2.2099609465997734 ns/iter 0.99
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.185589494658582 ns/iter 2.201903645447679 ns/iter 0.99
Regex_Period_Asterisk 2.1840158437359656 ns/iter 2.2027075997977814 ns/iter 0.99
Regex_Group_Period_Asterisk_Group 2.1841528728352 ns/iter 2.2030467758563295 ns/iter 0.99
Regex_Period_Plus 2.247423229188158 ns/iter 2.488285031623421 ns/iter 0.90
Regex_Period 2.2038767822296395 ns/iter 2.4862767005306874 ns/iter 0.89
Regex_Caret_Period_Plus_Dollar 2.2010225773726 ns/iter 2.4870033898974846 ns/iter 0.89
Regex_Caret_Group_Period_Plus_Group_Dollar 2.200534965390663 ns/iter 2.49093211272742 ns/iter 0.88
Regex_Caret_Period_Asterisk_Dollar 2.4891360564272786 ns/iter 3.4219833621083935 ns/iter 0.73
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.4873844860501424 ns/iter 2.202550256108647 ns/iter 1.13
Regex_Caret_X_Hyphen 12.495306862752871 ns/iter 12.565605392116515 ns/iter 0.99
Regex_Period_Md_Dollar 73.84686866952421 ns/iter 73.55546144623383 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 7.153590014153352 ns/iter 6.216454784509748 ns/iter 1.15
Regex_Caret_Period_Range_Dollar 3.7296781409314548 ns/iter 2.9760744550740563 ns/iter 1.25
Regex_Nested_Backtrack 498.23798826493726 ns/iter 501.3591780000297 ns/iter 0.99
Pointer_Object_Traverse 44.842051378894354 ns/iter 44.84968504844869 ns/iter 1.00
Pointer_Object_Try_Traverse 52.286278831395585 ns/iter 52.27804925625326 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 352.1140253507114 ns/iter 352.0166325683418 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: c56aa68 Previous: e3d4f14 Ratio
JSON_Array_Of_Objects_Unique 414.25443526303906 ns/iter 418.81653195799527 ns/iter 0.99
JSON_Parse_1 81810.21829382534 ns/iter 82376.81799919019 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 54.17576785713354 ns/iter 53.51917857142651 ns/iter 1.01
JSON_Equality_Helm_Chart_Lock 212.77712500001655 ns/iter 219.02413531141934 ns/iter 0.97
Regex_Lower_S_Or_Upper_S_Asterisk 8.546314247561288 ns/iter 8.183487500000197 ns/iter 1.04
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 7.890772732629629 ns/iter 7.996433000016435 ns/iter 0.99
Regex_Period_Asterisk 8.41389508928663 ns/iter 7.764679687500831 ns/iter 1.08
Regex_Group_Period_Asterisk_Group 7.9827500000005465 ns/iter 8.16469282069353 ns/iter 0.98
Regex_Period_Plus 7.817450857957997 ns/iter 7.937702643134225 ns/iter 0.98
Regex_Period 7.829800223215143 ns/iter 8.044958705357073 ns/iter 0.97
Regex_Caret_Period_Plus_Dollar 7.935472098216577 ns/iter 7.933171874999597 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 8.16963344567164 ns/iter 8.095683446000894 ns/iter 1.01
Regex_Caret_Period_Asterisk_Dollar 7.920328124999543 ns/iter 8.156839249298837 ns/iter 0.97
Regex_Caret_Group_Period_Asterisk_Group_Dollar 7.848369419643271 ns/iter 8.844378124999608 ns/iter 0.89
Regex_Caret_X_Hyphen 11.693685714285655 ns/iter 11.694298437500805 ns/iter 1.00
Regex_Period_Md_Dollar 141.55185305571715 ns/iter 148.1656473214394 ns/iter 0.96
Regex_Caret_Slash_Period_Asterisk 11.630474999999967 ns/iter 11.745619642856095 ns/iter 0.99
Regex_Caret_Period_Range_Dollar 8.822090585615564 ns/iter 8.984697281318923 ns/iter 0.98
Regex_Nested_Backtrack 586.3744642858088 ns/iter 592.1585714286185 ns/iter 0.99
Pointer_Object_Traverse 56.058789999997316 ns/iter 56.27767857142934 ns/iter 1.00
Pointer_Object_Try_Traverse 75.73923214284913 ns/iter 75.87578124999946 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 188.6429632717126 ns/iter 174.43887105616898 ns/iter 1.08

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: c56aa68 Previous: e3d4f14 Ratio
Pointer_Object_Traverse 44.353420559122036 ns/iter 43.8938553628957 ns/iter 1.01
Pointer_Object_Try_Traverse 22.432882622343456 ns/iter 22.464979118431287 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 213.3512660128229 ns/iter 213.2510941883446 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 2.4878500472198515 ns/iter 3.221349417382267 ns/iter 0.77
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.487999377328308 ns/iter 3.166731024562928 ns/iter 0.79
Regex_Period_Asterisk 2.488064791584706 ns/iter 3.1476046160116873 ns/iter 0.79
Regex_Group_Period_Asterisk_Group 2.487058484219547 ns/iter 3.1452689074763334 ns/iter 0.79
Regex_Period_Plus 2.707357450070652 ns/iter 3.13354708986803 ns/iter 0.86
Regex_Period 2.4862103961505673 ns/iter 3.2366515618481935 ns/iter 0.77
Regex_Caret_Period_Plus_Dollar 2.487669755171694 ns/iter 3.2392018040159503 ns/iter 0.77
Regex_Caret_Group_Period_Plus_Group_Dollar 2.487102598875772 ns/iter 3.200302142985193 ns/iter 0.78
Regex_Caret_Period_Asterisk_Dollar 2.803023990076224 ns/iter 3.7268628517323394 ns/iter 0.75
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.797420884167343 ns/iter 3.7268774419745183 ns/iter 0.75
Regex_Caret_X_Hyphen 12.430609351007067 ns/iter 12.425781608117006 ns/iter 1.00
Regex_Period_Md_Dollar 89.2869073864057 ns/iter 89.08450340373336 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 7.144664196250504 ns/iter 7.150290633605439 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 4.039434378593833 ns/iter 4.042004651659798 ns/iter 1.00
Regex_Nested_Backtrack 811.8952150927557 ns/iter 813.4009478738701 ns/iter 1.00
JSON_Array_Of_Objects_Unique 378.3210239542272 ns/iter 380.3190096905847 ns/iter 0.99
JSON_Parse_1 32750.898867992524 ns/iter 32668.460258865216 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 64.328028415102 ns/iter 62.929597923582065 ns/iter 1.02
JSON_Equality_Helm_Chart_Lock 142.41912687601393 ns/iter 143.29627354241185 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 4db0ded into main Jan 2, 2025
13 checks passed
@jviotti jviotti deleted the keywords-header branch January 2, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant